From patchwork Mon Mar 26 14:06:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paolo Valente X-Patchwork-Id: 10307885 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1A079600CC for ; Mon, 26 Mar 2018 14:06:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1002D2885C for ; Mon, 26 Mar 2018 14:06:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0353528A77; Mon, 26 Mar 2018 14:06:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5B9292885C for ; Mon, 26 Mar 2018 14:06:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751840AbeCZOGm (ORCPT ); Mon, 26 Mar 2018 10:06:42 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:37977 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbeCZOGl (ORCPT ); Mon, 26 Mar 2018 10:06:41 -0400 Received: by mail-wm0-f67.google.com with SMTP id l16so15783903wmh.3 for ; Mon, 26 Mar 2018 07:06:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=Q5tZPtJoXlSguzH6IrDNVd99Sdo2dEYw82S2wEugmkc=; b=cvX5L0UMZhKDK/VHKCGwEjl9rrc1UJXRamb+o/uKARdcKN8L13SFjcwIi/xiLJ59fi f/F+7H0skScOMcpT1n424XgAaweM5b9Q1VwO4oQ8Y+aZNRpFHUKlfnbXkrDHmLwaE/0K bU9mPZr8IioDNZsalyxfoFUXeRePjboFHwgOc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Q5tZPtJoXlSguzH6IrDNVd99Sdo2dEYw82S2wEugmkc=; b=ZKicx5SmqJvzzJJQgeXrvSuao68fFpSa9fiNMPASCQ5h8WEjVB3VCJSKCJXTWcY+0h U5CiGa2ODgyXVSqxOxJWXcNN9npGsf/2ENsd/6xpOWcsE41DHlkADmnBorDTmB68lMlA G/823XWnWNpy2NPPd4YTS4P98q46R4oGHaYFnwv2MPMTN/vGT6MFO2VfpIJ0kWFpERkY sKlL+8ClmWwbMGzo510uYerI+3qe2xFlGyxLc92S3XSzS0vF93/0tP0mSxPdnsymmVXW LA3O++dcsf6HSZvDXeRx7+KXRXsPMMIiyWL2BapP3s8qr4YuaQYsuwA9b81i3N7YBIbH 0zoA== X-Gm-Message-State: AElRT7H+qXgpGb/d5SZ/KMnmiEndrjx43NArLkJORe6p4+mljL0Zu/7k Zp8NpAHkMEssMxokDTgNDOmtluqochI= X-Google-Smtp-Source: AG47ELvWmYcdEaFh6ejf1pyUpLhZMMtfZ1WgwQz16qNSKMqe4kI71tQmSvTZv+HEbnUMTChMZJBbAA== X-Received: by 10.28.177.86 with SMTP id a83mr15224241wmf.143.1522073200400; Mon, 26 Mar 2018 07:06:40 -0700 (PDT) Received: from localhost.localdomain (146-241-17-196.dyn.eolo.it. [146.241.17.196]) by smtp.gmail.com with ESMTPSA id c187sm3912642wmf.18.2018.03.26.07.06.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Mar 2018 07:06:39 -0700 (PDT) From: Paolo Valente To: Jens Axboe Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, ulf.hansson@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, bfq-iosched@googlegroups.com, oleksandr@natalenko.name, khlebnikov@yandex-team.ru, Paolo Valente Subject: [PATCH BUGFIX] block, bfq: lower-bound the estimated peak rate to 1 Date: Mon, 26 Mar 2018 16:06:24 +0200 Message-Id: <20180326140624.2295-1-paolo.valente@linaro.org> X-Mailer: git-send-email 2.16.1 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If a storage device handled by BFQ happens to be slower than 7.5 KB/s for a certain amount of time (in the order of a second), then the estimated peak rate of the device, maintained in BFQ, becomes equal to 0. The reason is the limited precision with which the rate is represented (details on the range of representable values in the comments introduced by this commit). This leads to a division-by-zero error where the estimated peak rate is used as divisor. Such a type of failure has been reported in [1]. This commit addresses this issue by: 1. Lower-bounding the estimated peak rate to 1 2. Adding and improving comments on the range of rates representable [1] https://www.spinics.net/lists/kernel/msg2739205.html Signed-off-by: Konstantin Khlebnikov Signed-off-by: Paolo Valente --- block/bfq-iosched.c | 25 ++++++++++++++++++++++++- block/bfq-iosched.h | 2 +- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/block/bfq-iosched.c b/block/bfq-iosched.c index aeca22d91101..f0ecd98509d8 100644 --- a/block/bfq-iosched.c +++ b/block/bfq-iosched.c @@ -201,7 +201,20 @@ static struct kmem_cache *bfq_pool; /* Target observation time interval for a peak-rate update (ns) */ #define BFQ_RATE_REF_INTERVAL NSEC_PER_SEC -/* Shift used for peak rate fixed precision calculations. */ +/* + * Shift used for peak-rate fixed precision calculations. + * With + * - the current shift: 16 positions + * - the current type used to store rate: u32 + * - the current unit of measure for rate: [sectors/usec], or, more precisely, + * [(sectors/usec) / 2^BFQ_RATE_SHIFT] to take into account the shift, + * the range of rates that can be stored is + * [1 / 2^BFQ_RATE_SHIFT, 2^(32 - BFQ_RATE_SHIFT)] sectors/usec = + * [1 / 2^16, 2^16] sectors/usec = [15e-6, 65536] sectors/usec = + * [15, 65G] sectors/sec + * Which, assuming a sector size of 512B, corresponds to a range of + * [7.5K, 33T] B/sec + */ #define BFQ_RATE_SHIFT 16 /* @@ -2637,6 +2650,16 @@ static void bfq_update_rate_reset(struct bfq_data *bfqd, struct request *rq) rate /= divisor; /* smoothing constant alpha = 1/divisor */ bfqd->peak_rate += rate; + + /* + * For a very slow device, bfqd->peak_rate can reach 0 (see + * the minimum representable values reported in the comments + * on BFQ_RATE_SHIFT). Push to 1 if this happens, to avoid + * divisions by zero where bfqd->peak_rate is used as a + * divisor. + */ + bfqd->peak_rate = max_t(u32, 1, bfqd->peak_rate); + update_thr_responsiveness_params(bfqd); reset_computation: diff --git a/block/bfq-iosched.h b/block/bfq-iosched.h index 350c39ae2896..ae2f3dadec44 100644 --- a/block/bfq-iosched.h +++ b/block/bfq-iosched.h @@ -499,7 +499,7 @@ struct bfq_data { u64 delta_from_first; /* * Current estimate of the device peak rate, measured in - * [BFQ_RATE_SHIFT * sectors/usec]. The left-shift by + * [(sectors/usec) / 2^BFQ_RATE_SHIFT]. The left-shift by * BFQ_RATE_SHIFT is performed to increase precision in * fixed-point calculations. */