From patchwork Fri Jun 15 21:55:18 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10467731 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 53587601C2 for ; Fri, 15 Jun 2018 21:55:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4370028E67 for ; Fri, 15 Jun 2018 21:55:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3850B28EA2; Fri, 15 Jun 2018 21:55:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C9ED828E63 for ; Fri, 15 Jun 2018 21:55:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756585AbeFOVzZ (ORCPT ); Fri, 15 Jun 2018 17:55:25 -0400 Received: from esa4.hgst.iphmx.com ([216.71.154.42]:27179 "EHLO esa4.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756488AbeFOVzX (ORCPT ); Fri, 15 Jun 2018 17:55:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1529099724; x=1560635724; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=zsARfZy6iiaVCdWrCdrviKXHQJOOVCdWcB10aPHV8xs=; b=lIyFULRRcS0Y8Jb6f15t1myTeiQDFHaqJLXEnlkJyKA9waL5/D1iDscQ 4tIEuK9OJsvdgcUJ1MG5nVYBtSjgGuxu1gE+G/W0CULg9sfE628JRpKw+ ZK1G+G9Be17sL9zy6yhXBuMsY9F3Kh6fDE0GXKuL1+MoFl2w0QO7VMFCR Os+rsWMPefUd7qI6VuCFCfM2dPWR9s6dR1AfJa/QIKfBGCDNnMEZbevDO OJPxK9C4EPtcOB8cyAIZFhxvn92BSpXox5qWpCj6x80Mq3gr904IvS70s pgiVixxt79EPsnx4rNWtaTU7Z8v6CiEq/WR3289iZpHUG+VLLw7z7Ssd7 A==; X-IronPort-AV: E=Sophos;i="5.51,228,1526313600"; d="scan'208";a="80546944" Received: from h199-255-45-14.hgst.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 16 Jun 2018 05:55:23 +0800 Received: from uls-op-cesaip01.wdc.com ([10.248.3.36]) by uls-op-cesaep01.wdc.com with ESMTP; 15 Jun 2018 14:45:30 -0700 Received: from thinkpad-bart.sdcorp.global.sandisk.com ([10.111.67.248]) by uls-op-cesaip01.wdc.com with ESMTP; 15 Jun 2018 14:55:23 -0700 From: Bart Van Assche To: Jens Axboe Cc: linux-block@vger.kernel.org, Christoph Hellwig , Bart Van Assche , Matias Bjorling Subject: [PATCH 2/5] include/uapi/linux/blkzoned.h: Remove a superfluous __packed directive Date: Fri, 15 Jun 2018 14:55:18 -0700 Message-Id: <20180615215521.27435-3-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20180615215521.27435-1-bart.vanassche@wdc.com> References: <20180615215521.27435-1-bart.vanassche@wdc.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Using the __packed directive for a structure that does not need it is wrong because it makes gcc generate suboptimal code on some architectures. Hence remove the __packed directive from the blk_zone_report structure definition. See also http://digitalvampire.org/blog/index.php/2006/07/31/why-you-shouldnt-use-__attribute__packed/. Signed-off-by: Bart Van Assche Reviewed-by: Damien Le Moal Cc: Matias Bjorling Cc: Christoph Hellwig --- include/uapi/linux/blkzoned.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/uapi/linux/blkzoned.h b/include/uapi/linux/blkzoned.h index e3c70fe6bf0f..ff5a5db8906a 100644 --- a/include/uapi/linux/blkzoned.h +++ b/include/uapi/linux/blkzoned.h @@ -117,7 +117,7 @@ struct blk_zone_report { __u32 nr_zones; __u8 reserved[4]; struct blk_zone zones[0]; -} __packed; +}; /** * struct blk_zone_range - BLKRESETZONE ioctl request