| Message ID | 20180619045216.21130-4-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19/06/18 07:52, Christoph Hellwig wrote: > The mirroring code never changes the bio data or biovecs. This means > we can reuse the biovec allocation easily instead of duplicating it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Thank you yes that's much better ACK-by Boaz Harrosh <ooo@electrozaur.com> > --- > fs/exofs/ore.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c > index 1b8b44637e70..5331a15a61f1 100644 > --- a/fs/exofs/ore.c > +++ b/fs/exofs/ore.c > @@ -873,8 +873,8 @@ static int _write_mirror(struct ore_io_state *ios, int cur_comp) > struct bio *bio; > > if (per_dev != master_dev) { > - bio = bio_clone_kmalloc(master_dev->bio, > - GFP_KERNEL); > + bio = bio_clone_fast(master_dev->bio, > + GFP_KERNEL, NULL); > if (unlikely(!bio)) { > ORE_DBGMSG( > "Failed to allocate BIO size=%u\n", >
diff --git a/fs/exofs/ore.c b/fs/exofs/ore.c index 1b8b44637e70..5331a15a61f1 100644 --- a/fs/exofs/ore.c +++ b/fs/exofs/ore.c @@ -873,8 +873,8 @@ static int _write_mirror(struct ore_io_state *ios, int cur_comp) struct bio *bio; if (per_dev != master_dev) { - bio = bio_clone_kmalloc(master_dev->bio, - GFP_KERNEL); + bio = bio_clone_fast(master_dev->bio, + GFP_KERNEL, NULL); if (unlikely(!bio)) { ORE_DBGMSG( "Failed to allocate BIO size=%u\n",
The mirroring code never changes the bio data or biovecs. This means we can reuse the biovec allocation easily instead of duplicating it. Signed-off-by: Christoph Hellwig <hch@lst.de> --- fs/exofs/ore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)