From patchwork Tue Jun 19 20:23:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bart Van Assche X-Patchwork-Id: 10475411 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4072C6029B for ; Tue, 19 Jun 2018 20:24:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 31E7A286B2 for ; Tue, 19 Jun 2018 20:24:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2683E28BE8; Tue, 19 Jun 2018 20:24:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BCFCB286B2 for ; Tue, 19 Jun 2018 20:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967148AbeFSUYp (ORCPT ); Tue, 19 Jun 2018 16:24:45 -0400 Received: from esa1.hgst.iphmx.com ([68.232.141.245]:61047 "EHLO esa1.hgst.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967197AbeFSUYQ (ORCPT ); Tue, 19 Jun 2018 16:24:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=wdc.com; i=@wdc.com; q=dns/txt; s=dkim.wdc.com; t=1529439856; x=1560975856; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=qkltVnQJtk0/usLUsbiBKkchcHBRlxhvo6fkYZwdyCA=; b=bNvBucPPFUQscwhGNpySSMO71LKHNdDiOSFS0rvV33VbueAnINhBAKeI QPlnL+oQ5KLSIG/0dRjz8mTvWdoSAvZF0qv642eLRbPjSyFo1rriowl7F VeVmKmbSkyf8MytH6P9oTMncOC0AkzQWabkcKW0U9mZqs7ZxdLuj5iIHB K8XbUTPwT17l71W2ZlLwzyRuV/129TfzoIKrrP6ZotUm0afMQJoCRLUO7 YQTwnsyZPvi02veRgtwpPkjydoS0zU7U/6SSmckC5m8/7AcCG/DslXkc4 J5p8TrFm72UuUEvEbOGeOWJGxOahFiATth5S3s3ZZXMfj3V0RMfyNl8mi Q==; X-IronPort-AV: E=Sophos;i="5.51,244,1526313600"; d="scan'208";a="184292012" Received: from uls-op-cesaip01.wdc.com (HELO uls-op-cesaep01.wdc.com) ([199.255.45.14]) by ob1.hgst.iphmx.com with ESMTP; 20 Jun 2018 04:23:56 +0800 Received: from uls-op-cesaip02.wdc.com ([10.248.3.37]) by uls-op-cesaep01.wdc.com with ESMTP; 19 Jun 2018 13:13:48 -0700 Received: from thinkpad-bart.sdcorp.global.sandisk.com ([10.111.67.248]) by uls-op-cesaip02.wdc.com with ESMTP; 19 Jun 2018 13:23:56 -0700 From: Bart Van Assche To: Omar Sandoval Cc: linux-block@vger.kernel.org, Bart Van Assche , Chaitanya Kulkarni Subject: [PATCH 6/9] Multiple tests: remove unused and undefined variables Date: Tue, 19 Jun 2018 13:23:50 -0700 Message-Id: <20180619202353.23631-7-bart.vanassche@wdc.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180619202353.23631-1-bart.vanassche@wdc.com> References: <20180619202353.23631-1-bart.vanassche@wdc.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Bart Van Assche Cc: Chaitanya Kulkarni Reviewed-by: Johannes Thumshirn --- tests/loop/003 | 3 --- tests/nvme/010 | 3 +-- tests/nvme/011 | 3 +-- tests/nvme/012 | 1 - tests/nvme/013 | 1 - 5 files changed, 2 insertions(+), 9 deletions(-) diff --git a/tests/loop/003 b/tests/loop/003 index 353d4fcfa33c..6f6fa8d18ebe 100755 --- a/tests/loop/003 +++ b/tests/loop/003 @@ -28,11 +28,8 @@ requires() { } test() { - local loop_dev echo "Running ${TEST_NAME}" - loop_dev="$(losetup -f)" - # In a subshell so TIMEFORMAT doesn't get clobbered. ( TIMEFORMAT="Test took %0R seconds" diff --git a/tests/nvme/010 b/tests/nvme/010 index 956c6597a374..b6849dbad375 100755 --- a/tests/nvme/010 +++ b/tests/nvme/010 @@ -38,7 +38,6 @@ test() { modprobe nvme-loop local port - local ret=0 local nvmedev local loop_dev local file_path="${TMPDIR}/img" @@ -70,7 +69,7 @@ test() { losetup -d "${loop_dev}" rm "${file_path}" - rm -f local*verify*state "${fio_out}" + rm -f local*verify*state modprobe -r nvme_loop modprobe -r nvmet diff --git a/tests/nvme/011 b/tests/nvme/011 index 872a99af4f8c..f26eb155809c 100755 --- a/tests/nvme/011 +++ b/tests/nvme/011 @@ -37,7 +37,6 @@ test() { modprobe nvme-loop local port - local ret=0 local nvmedev local file_path local file_path="${TMPDIR}/img" @@ -65,7 +64,7 @@ test() { _remove_nvmet_port "${port}" rm "${file_path}" - rm -f local-write-and-verify*state "${fio_out}" + rm -f local-write-and-verify*state modprobe -r nvme_loop modprobe -r nvmet diff --git a/tests/nvme/012 b/tests/nvme/012 index 8f632b30734d..e570793dd5db 100755 --- a/tests/nvme/012 +++ b/tests/nvme/012 @@ -38,7 +38,6 @@ test() { modprobe nvme-loop local port - local ret=0 local nvmedev local loop_dev local mount_dir="/mnt/blktests" diff --git a/tests/nvme/013 b/tests/nvme/013 index 0ccb083b175b..247fe9f252fa 100755 --- a/tests/nvme/013 +++ b/tests/nvme/013 @@ -38,7 +38,6 @@ test() { modprobe nvme-loop local port - local ret=0 local nvmedev local mount_dir="/mnt/blktests/" local file_path="${TMPDIR}/img"