From patchwork Wed Jun 20 10:44:35 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 10476899 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 95D6D60230 for ; Wed, 20 Jun 2018 10:45:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 83AD128DD5 for ; Wed, 20 Jun 2018 10:45:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 760D528E19; Wed, 20 Jun 2018 10:45:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DEFC728DD5 for ; Wed, 20 Jun 2018 10:45:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752871AbeFTKpD (ORCPT ); Wed, 20 Jun 2018 06:45:03 -0400 Received: from aserp2130.oracle.com ([141.146.126.79]:52620 "EHLO aserp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752838AbeFTKpC (ORCPT ); Wed, 20 Jun 2018 06:45:02 -0400 Received: from pps.filterd (aserp2130.oracle.com [127.0.0.1]) by aserp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w5KAhXLI067317; Wed, 20 Jun 2018 10:44:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : mime-version : content-type; s=corp-2017-10-26; bh=4IPrCmJEVJnUgpp4bSJwVUroVSGT186C+B2uOVVqXnU=; b=s6jtQftMSjGFdpHXb7pUCNkoGhtMYh7KilRyOS56gCeqhbrpPorMUkz/laj2JhmNhKLV R2q54TVSzKGadJRHJsl4KreEs2GO1YmGCnoBm9jrMZZlDnc8zi8BLjHEzOvF2mSZOX6k 8XaxSHNeMBXQ32lrMaoFF9F5E19BFrNSrlK7JYv8ZF3A5Bi+BaEUa1sF/xQO9shXgyJ8 jJUDXEXebfqPhjlQ/1B8K6w/ZWDBNkbk+qe7TGIY8sGSmI+yz3DZdqm6Z6Du4SU0LJgk t/XkWfM4rncQ4lpTC4Yprsmh06Io3dISVaecAm7oT/t9ntAKjBIS6vNS8SYQS4ymcB2h mg== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp2130.oracle.com with ESMTP id 2jmr2mm1xe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Jun 2018 10:44:46 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w5KAij9p022701 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Jun 2018 10:44:45 GMT Received: from abhmp0002.oracle.com (abhmp0002.oracle.com [141.146.116.8]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id w5KAihSp023835; Wed, 20 Jun 2018 10:44:44 GMT Received: from kili.mountain (/197.157.34.185) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 20 Jun 2018 03:44:43 -0700 Date: Wed, 20 Jun 2018 13:44:35 +0300 From: Dan Carpenter To: "Richard Russon (FlatCap)" Cc: Jens Axboe , linux-ntfs-dev@lists.sourceforge.net, linux-block@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] partitions/ldm: Off by one in ldm_relative() Message-ID: <20180620104433.qegf5bakvcywzuga@kili.mountain> MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170113 (1.7.2) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8929 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=555 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806200123 Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If base == buflen then we read one character past the end of buffer[]. Signed-off-by: Dan Carpenter --- This is static analysis. Not tested. This code goes back to before the start of git. diff --git a/block/partitions/ldm.c b/block/partitions/ldm.c index 0417937dfe99..8f4c302eb11b 100644 --- a/block/partitions/ldm.c +++ b/block/partitions/ldm.c @@ -636,12 +636,12 @@ static int ldm_relative(const u8 *buffer, int buflen, int base, int offset) { base += offset; - if (!buffer || offset < 0 || base > buflen) { + if (!buffer || offset < 0 || base >= buflen) { if (!buffer) ldm_error("!buffer"); if (offset < 0) ldm_error("offset (%d) < 0", offset); - if (base > buflen) + if (base >= buflen) ldm_error("base (%d) > buflen (%d)", base, buflen); return -1; }