From patchwork Tue Jul 3 15:14:51 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10504453 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3A1D0601D3 for ; Tue, 3 Jul 2018 15:20:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2BA24287DC for ; Tue, 3 Jul 2018 15:20:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 29F0F28C90; Tue, 3 Jul 2018 15:20:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CEA36287DC for ; Tue, 3 Jul 2018 15:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933689AbeGCPUE (ORCPT ); Tue, 3 Jul 2018 11:20:04 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:38827 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933717AbeGCPPK (ORCPT ); Tue, 3 Jul 2018 11:15:10 -0400 Received: by mail-qt0-f195.google.com with SMTP id c5-v6so1865553qth.5 for ; Tue, 03 Jul 2018 08:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=gkdJSYLh9LN7Ss8j0Rn9mX3g9Rqhn9vecXPFB0z5w9o=; b=rrJkMw9td3K4lUzUDyX2Al0CdqoicFVk+1YE+PqsAkvDgs5eN40uLaF7U9xzx0/Hql WtfifV7wvs6WKR2wFcjO+XbMdo2NDSqi9eCLZrI3ZvoAHzhqLuogxL02+x+NPm2uNgFC GoHnSuQ3D5hx5h9Pls5eAfYIwzdlv7l5cWX4WQGxri3/YPsYH6oYYhKBLubVO43BYkUZ mzB+A46Di5VPYe9wcveeVoz+q/9WSBbRNAwfg/o+ftXc85VHd8wMrYs5HbIlcZelMljh JimjPvW5cth+MGoOlVcD8r/+oe4WLm0bE0/cqcnS4QYRhacZDw3O2oNEm3Jv413ewNPw e83g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=gkdJSYLh9LN7Ss8j0Rn9mX3g9Rqhn9vecXPFB0z5w9o=; b=MT+8tsZRSQ0mWIw7afW9din9KmTa4yRyPsVNNcFJ/d3HTC6hwlt7qWT/FaHh2ss6sv DnQWZIranfsVLBiZDDXLs/oNkL4VwpwMomnkaIj0Pm9UubIjHIBk5nHNmgb4SPY3smIR IEDsj4HGQCnVI7ymDUWSSzGD7cZxaFKwduVtG3OBeiU+EbOQIAtEqyUnaPDgV7sYN9bM Q5XZNHXVtU0Po7GsbT7PwF3nTAB+idU7lTnd07T2kXTAuXrqPJAgqvdq4m3zkEJDVHTC 4xmGG2jgD6AhBerLluS+Hlm8Twtoao8vvEvYDSni9xv+oJuI0eO2Vds+7i1InUFdqSPo Th4A== X-Gm-Message-State: APt69E1u3FPAYVwhmUcZ//DG54Q4zF+eM/QxvUNPPMgh4wfdRjiclKW+ tcUki7YSMsSMGCSp4rV8fa84lx147vQ= X-Google-Smtp-Source: AAOMgpdaMyoYbchZo3CC7FlkhpC7ldJlRiKeCYbgRKUQ+ThtMhX42jqEZixXZ9K063ljkPhlGxoD+A== X-Received: by 2002:ac8:3274:: with SMTP id y49-v6mr16177950qta.194.1530630909327; Tue, 03 Jul 2018 08:15:09 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id y131-v6sm773495qka.30.2018.07.03.08.15.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Jul 2018 08:15:08 -0700 (PDT) From: Josef Bacik To: axboe@kernel.dk, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, hannes@cmpxchg.org, tj@kernel.org, linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, kernel-team@fb.com Cc: Josef Bacik Subject: [PATCH 02/14] block: introduce bio_issue_as_root_blkg Date: Tue, 3 Jul 2018 11:14:51 -0400 Message-Id: <20180703151503.2549-3-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180703151503.2549-1-josef@toxicpanda.com> References: <20180703151503.2549-1-josef@toxicpanda.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Josef Bacik Instead of forcing all file systems to get the right context on their bio's, simply check for REQ_META to see if we need to issue as the root blkg. We don't want to force all bio's to have the root blkg associated with them if REQ_META is set, as some controllers (blk-iolatency) need to know who the originating cgroup is so it can backcharge them for the work they are doing. This helper will make sure that the controllers do the proper thing wrt the IO priority and backcharging. Signed-off-by: Josef Bacik Acked-by: Tejun Heo --- include/linux/blk-cgroup.h | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/include/linux/blk-cgroup.h b/include/linux/blk-cgroup.h index 6c666fd7de3c..69aa71dc0c04 100644 --- a/include/linux/blk-cgroup.h +++ b/include/linux/blk-cgroup.h @@ -238,6 +238,22 @@ static inline struct blkcg *bio_blkcg(struct bio *bio) return css_to_blkcg(task_css(current, io_cgrp_id)); } +/** + * bio_issue_as_root_blkg - see if this bio needs to be issued as root blkg + * @return: true if this bio needs to be submitted with the root blkg context. + * + * In order to avoid priority inversions we sometimes need to issue a bio as if + * it were attached to the root blkg, and then backcharge to the actual owning + * blkg. The idea is we do bio_blkcg() to look up the actual context for the + * bio and attach the appropriate blkg to the bio. Then we call this helper and + * if it is true run with the root blkg for that queue and then do any + * backcharging to the originating cgroup once the io is complete. + */ +static inline bool bio_issue_as_root_blkg(struct bio *bio) +{ + return (bio->bi_opf & REQ_META); +} + /** * blkcg_parent - get the parent of a blkcg * @blkcg: blkcg of interest