From patchwork Tue Jul 10 19:57:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Omar Sandoval X-Patchwork-Id: 10517977 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 517296020F for ; Tue, 10 Jul 2018 19:57:14 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3CF5D28F40 for ; Tue, 10 Jul 2018 19:57:14 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 30B5128F4A; Tue, 10 Jul 2018 19:57:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A878B28F40 for ; Tue, 10 Jul 2018 19:57:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732464AbeGJT5k (ORCPT ); Tue, 10 Jul 2018 15:57:40 -0400 Received: from mail-pl0-f67.google.com ([209.85.160.67]:32990 "EHLO mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732205AbeGJT5k (ORCPT ); Tue, 10 Jul 2018 15:57:40 -0400 Received: by mail-pl0-f67.google.com with SMTP id 6-v6so8076234plb.0 for ; Tue, 10 Jul 2018 12:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osandov-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=rTa6aAnRdW+YLT5AwBbPCaeUFH6z8H6mwlR5RkrtzjE=; b=qPVq9M1Gs8AEu/wIwoD5xP+A9TW7rMheNnDsRbvjo14TPxwPdjEpmg6Oh7Mi2rRk3a qi2wKzMmBAtXcpN5Fh+PvYgD5Zxny1l6UXtzORMWO96oYsoNp5cGSStlP2YneeQoz5SB vACwDlwIxlbkTEMhh6PqziDKGJl8bCDiCZ+P622OL4ioJDTVblio+zAT74dXM6tgn2ph s0Ve/5/sGAy/KrSPconjZ4yO3MYiKcPLII+XXEOv+ioONhQ/bBF6inC65tzr4q6O5gtI ZtyhAR7Tg7QILDKPjYs7S69uwoi6Bv5QBRwTqOCN9sJypzYHV7wXniRF5+qd3qF0Aek0 usSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=rTa6aAnRdW+YLT5AwBbPCaeUFH6z8H6mwlR5RkrtzjE=; b=pJ6TwAdysuLLiuqREZD/AytjKOEiFkP19g1hgGdAcExi6e11sJErXQjuxKcTW487+T wwM2yvzqGC+YiuD/Kcrt4KdFxJ0TqAtQyMFuF5QBlq/H19tVcbol2s8HFuqYw8g2yERW 8nkCzi6U8yiCcty7f02TpgdgyshD7TMNE9Fyo/N47IdbiHoatkrlXJK0+alqf6RO5BG+ ybTQ/Wr6REurTAXWmLDl0Bk3XWuyn92P+ZVxvR028xJNU4kcALUOJw8SLyhR6yijtphy q4TZaaLTFupLmYnXycxO6gJy9Jk1fYv1XCmyc4t9sgbGr8R5ARo7LmL838KBSCpIbqke rvCQ== X-Gm-Message-State: APt69E0I85mfPDWTb397oJedltfsU9G/JVd4aGlQ3mNhvNMZeh59Nysd kM0leqqvZbLjbaT84if/MVhb7g== X-Google-Smtp-Source: AAOMgpeSuooAVXrKgPA4D3lzaN0dOr5aktDdn37hfdn+d7b+WFZxdrl9ZGkqJGGCicbG1R9LRMdpTg== X-Received: by 2002:a17:902:b115:: with SMTP id q21-v6mr25623225plr.97.1531252626095; Tue, 10 Jul 2018 12:57:06 -0700 (PDT) Received: from vader ([2620:10d:c090:180::1:e18b]) by smtp.gmail.com with ESMTPSA id u71-v6sm10678311pfk.174.2018.07.10.12.57.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 10 Jul 2018 12:57:05 -0700 (PDT) Date: Tue, 10 Jul 2018 12:57:03 -0700 From: Omar Sandoval To: Bart Van Assche Cc: Omar Sandoval , linux-block@vger.kernel.org Subject: Re: [PATCH blktests v3 0/6] Add SRP initiator driver tests Message-ID: <20180710195703.GA16252@vader> References: <20180709225643.10537-1-bart.vanassche@wdc.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180709225643.10537-1-bart.vanassche@wdc.com> User-Agent: Mutt/1.10.0 (2018-05-17) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Mon, Jul 09, 2018 at 03:56:37PM -0700, Bart Van Assche wrote: > Hello Omar, > > As promised during LSF/MM, I have converted the srp-tests software to the > blktests framework. Please consider this patch series for inclusion in the > official blktests repository. This patch series is also available as a > github pull request, namely https://github.com/osandov/blktests/pull/24. > > Thanks, > > Bart. Awesome! $ sudo ./check srp srp/001 (Create and remove LUNs) [passed] runtime 2.260s ... 1.902s srp/002 (File I/O on top of multipath concurrently with logout and login (mq)) [passed] runtime 39.992s ... 38.689s srp/003 (File I/O on top of multipath concurrently with logout and login (sq)) [passed] runtime 10.071s ... 34.998s srp/004 (File I/O on top of multipath concurrently with logout and login (sq-on-mq)) [passed] runtime 10.077s ... 35.385s srp/005 (Direct I/O with large transfer sizes, cmd_sg_entries=255 and bs=4M) [passed] runtime 10.093s ... 14.184s srp/006 (Direct I/O with large transfer sizes, cmd_sg_entries=255 and bs=8M) [passed] runtime 10.171s ... 12.890s srp/007 (Direct I/O with large transfer sizes, cmd_sg_entries=1 and bs=4M) [passed] runtime 9.949s ... 14.197s srp/008 (Direct I/O with large transfer sizes, cmd_sg_entries=1 and bs=8M) [passed] runtime 10.029s ... 12.751s srp/009 (Buffered I/O with large transfer sizes, cmd_sg_entries=255 and bs=4M) [passed] runtime 11.805s ... 14.138s srp/010 (Buffered I/O with large transfer sizes, cmd_sg_entries=255 and bs=8M) [passed] runtime 10.267s ... 13.941s srp/011 (Block I/O on top of multipath concurrently with logout and login) [passed] runtime 11.087s ... 33.344s srp/012 (dm-mpath on top of multiple I/O schedulers) [passed] runtime 10.141s ... 10.954s srp/013 (Direct I/O using a discontiguous buffer) [passed] runtime 10.161s ... 3.721s As a further improvement, is it possible to configure multipathd to read from a custom configuration path? That way we could, e.g., dump the required multipath.conf in $TMPDIR instead of requiring the system-level configuration. If not, can you please make the group_requires automatically make the symlink instead of requiring it? Obviously checking if there was already a prod config file there. I also had to apply the following patch: Thanks, Bart! diff --git a/tests/srp/002 b/tests/srp/002 index c07e76f..74c5fee 100755 --- a/tests/srp/002 +++ b/tests/srp/002 @@ -45,6 +45,7 @@ test_disconnect_repeatedly() { } test() { + : "${TIMEOUT:=30}" trap 'trap "" EXIT; teardown' EXIT setup && test_disconnect_repeatedly && echo Passed } diff --git a/tests/srp/003 b/tests/srp/003 index fc85e29..9b8eeb4 100755 --- a/tests/srp/003 +++ b/tests/srp/003 @@ -45,6 +45,7 @@ test_disconnect_repeatedly() { } test() { + : "${TIMEOUT:=30}" trap 'trap "" EXIT; teardown' EXIT setup && test_disconnect_repeatedly && echo Passed } diff --git a/tests/srp/004 b/tests/srp/004 index 9c37fd2..1e8766a 100755 --- a/tests/srp/004 +++ b/tests/srp/004 @@ -45,6 +45,7 @@ test_disconnect_repeatedly() { } test() { + : "${TIMEOUT:=30}" trap 'trap "" EXIT; teardown' EXIT setup && test_disconnect_repeatedly && echo Passed } diff --git a/tests/srp/011 b/tests/srp/011 index 3561662..df99da5 100755 --- a/tests/srp/011 +++ b/tests/srp/011 @@ -41,6 +41,7 @@ test_disconnect_repeatedly() { } test() { + : "${TIMEOUT:=30}" trap 'trap "" EXIT; teardown' EXIT setup && test_disconnect_repeatedly && echo Passed }