From patchwork Mon Sep 10 20:49:28 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josef Bacik X-Patchwork-Id: 10594771 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id F1280920 for ; Mon, 10 Sep 2018 20:49:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E225E2933C for ; Mon, 10 Sep 2018 20:49:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D61D12933F; Mon, 10 Sep 2018 20:49:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 886522933C for ; Mon, 10 Sep 2018 20:49:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726800AbeIKBpb (ORCPT ); Mon, 10 Sep 2018 21:45:31 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:33002 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726150AbeIKBpb (ORCPT ); Mon, 10 Sep 2018 21:45:31 -0400 Received: by mail-qt0-f195.google.com with SMTP id r37-v6so25905280qtc.0 for ; Mon, 10 Sep 2018 13:49:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=mdb+zhmKePGqRxzXN1yXTDUiFJgfKxt1Fifg1WJguyE=; b=IWkt5gzPdmuLN7TuzwsPFdL/91uMUPQrxoWLGqXaN2UTaMfyEG9pHa9qbuLP3MO1oU ywDdnvKJn/z/B6FTO49f5XUd7pWwpLYMXvZJ4/hE394y5jm1mUZ3Hp/ZBRldcdBFGlbN Jd/FdWo1TxBWkmwqVLlkREBprsk5fL6dt9y7fIVwalYdjsDr3S2XhaGDEqwhJiEZZEQY WP2RpKybl51gID1W3Cwm9WC2isPZT+2ATrLoDLRY1giSq4vtA87pfwL3G3Xept6M6Rq9 xGly+8Rp2q6Avz9Q0cNf4KA8mK32EEqX4HWuSy180N6H0jJfOArOuxyIEvi+PLaUlB7N Ju6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=mdb+zhmKePGqRxzXN1yXTDUiFJgfKxt1Fifg1WJguyE=; b=V7zJ93a0Ryo0t8+OKimOdlpV8TJwchX2tUWJm8acTYSvveC2X4LRcyMoEgnIu/W8hX FnqFuLvqkz4jTfzUBP4YtXzW7DYptrKK0MQFs5bI0Wv5oeWdURgnbQEEdVF3VjsHuM1y cGnUt1oWoGlk+PfF++If8j6dHqu5x9cpUZ9hhcVDJlzYe/hBLXp/E7k4go1CvdbFCujN jIbeaFcoj5cGZ3KcGIEuAwHQQYMAVyrRa3HZAx5Yimyc0Ww3Ca8DeBv0SzeHxWVCQYRh zHPiZPHhUgbdNDkd1acdy9ASl0K7ZwdbuRauIlmqlbbd1HlW4gEZhvOSMJ5xGsnqoSi6 ozgg== X-Gm-Message-State: APzg51D+agfNgd8gPczXbPu3CVm/AScWaaQfFoEgoL4TS9laKtTIC1vG Xh84+5HY3oecVA/UyuEk6ajidg== X-Google-Smtp-Source: ANB0VdZyCrtNc0Jer62E+z+pfgPEFev73/auYJCwMiG/UEADqrUG/dorkxlrvtfnoTIwAGrM29G4Bg== X-Received: by 2002:ac8:1c89:: with SMTP id f9-v6mr17784750qtl.265.1536612578833; Mon, 10 Sep 2018 13:49:38 -0700 (PDT) Received: from localhost ([107.15.81.208]) by smtp.gmail.com with ESMTPSA id 62-v6sm10255033qkx.66.2018.09.10.13.49.37 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 10 Sep 2018 13:49:37 -0700 (PDT) From: Josef Bacik To: axboe@kernel.dk, kernel-team@fb.com, linux-block@vger.kernel.org Subject: [PATCH 2/6] blk-iolatency: delete changed variable Date: Mon, 10 Sep 2018 16:49:28 -0400 Message-Id: <20180910204932.14323-3-josef@toxicpanda.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <20180910204932.14323-1-josef@toxicpanda.com> References: <20180910204932.14323-1-josef@toxicpanda.com> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This was from a previous iteration when we returned whether or not we changed the scale. It is unused so remove it. Signed-off-by: Josef Bacik --- block/blk-iolatency.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c index 9b8d2012ea88..8f32aa1817f8 100644 --- a/block/blk-iolatency.c +++ b/block/blk-iolatency.c @@ -298,7 +298,6 @@ static void scale_change(struct iolatency_grp *iolat, bool up) unsigned long qd = iolat->blkiolat->rqos.q->nr_requests; unsigned long scale = scale_amount(qd, up); unsigned long old = iolat->rq_depth.max_depth; - bool changed = false; if (old > qd) old = qd; @@ -308,7 +307,6 @@ static void scale_change(struct iolatency_grp *iolat, bool up) return; if (old < qd) { - changed = true; old += scale; old = min(old, qd); iolat->rq_depth.max_depth = old; @@ -316,7 +314,6 @@ static void scale_change(struct iolatency_grp *iolat, bool up) } } else if (old > 1) { old >>= 1; - changed = true; iolat->rq_depth.max_depth = max(old, 1UL); } }