| Message ID | 20181008124121.20192-8-colyli@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bcache patches for 4.20 | expand |
On 10/8/18 6:41 AM, Coly Li wrote: > From: Ben Peddell <klightspeed@killerwolves.net> > > Forgot to include the maintainers with my first email. > > Somewhere between Michael Lyle's original > "bcache: PI controller for writeback rate V2" patch dated 07 Sep 2017 > and 1d316e6 bcache: implement PI controller for writeback rate, > the mapping of the writeback_rate_minimum attribute was dropped. > > Re-add the missing sysfs writeback_rate_minimum attribute mapping to > "allow the user to specify a minimum rate at which dirty blocks are > retired." > > Fixes: 1d316e6 bcache: implement PI controller for writeback rate Remember to use the correct format for the Fixes line.
On 2018/10/8 下午10:19, Jens Axboe wrote: > On 10/8/18 6:41 AM, Coly Li wrote: >> From: Ben Peddell <klightspeed@killerwolves.net> >> >> Forgot to include the maintainers with my first email. >> >> Somewhere between Michael Lyle's original >> "bcache: PI controller for writeback rate V2" patch dated 07 Sep 2017 >> and 1d316e6 bcache: implement PI controller for writeback rate, >> the mapping of the writeback_rate_minimum attribute was dropped. >> >> Re-add the missing sysfs writeback_rate_minimum attribute mapping to >> "allow the user to specify a minimum rate at which dirty blocks are >> retired." >> >> Fixes: 1d316e6 bcache: implement PI controller for writeback rate > > Remember to use the correct format for the Fixes line. > Hi Jens, This is my fault, it slips from my eyes. I'd like to resend a fixed up version to you. BTW, now I only use checkpatches.pl to check patch format, do you use extra scripts as format checking hooks ? Thanks. Coly Li
On 10/8/18 9:02 AM, Coly Li wrote: > On 2018/10/8 下午10:19, Jens Axboe wrote: >> On 10/8/18 6:41 AM, Coly Li wrote: >>> From: Ben Peddell <klightspeed@killerwolves.net> >>> >>> Forgot to include the maintainers with my first email. >>> >>> Somewhere between Michael Lyle's original >>> "bcache: PI controller for writeback rate V2" patch dated 07 Sep 2017 >>> and 1d316e6 bcache: implement PI controller for writeback rate, >>> the mapping of the writeback_rate_minimum attribute was dropped. >>> >>> Re-add the missing sysfs writeback_rate_minimum attribute mapping to >>> "allow the user to specify a minimum rate at which dirty blocks are >>> retired." >>> >>> Fixes: 1d316e6 bcache: implement PI controller for writeback rate >> >> Remember to use the correct format for the Fixes line. >> > > Hi Jens, > > This is my fault, it slips from my eyes. I'd like to resend a fixed up > version to you. I fixed it up when I applied it. > BTW, now I only use checkpatches.pl to check patch format, do you use > extra scripts as format checking hooks ? I don't use checkpatch, I just use my eye balls :-)
diff --git a/drivers/md/bcache/sysfs.c b/drivers/md/bcache/sysfs.c index 150cf4f4cf74..26f035a0c5b9 100644 --- a/drivers/md/bcache/sysfs.c +++ b/drivers/md/bcache/sysfs.c @@ -285,6 +285,7 @@ STORE(__cached_dev) 1, WRITEBACK_RATE_UPDATE_SECS_MAX); d_strtoul(writeback_rate_i_term_inverse); d_strtoul_nonzero(writeback_rate_p_term_inverse); + d_strtoul_nonzero(writeback_rate_minimum); sysfs_strtoul_clamp(io_error_limit, dc->error_limit, 0, INT_MAX); @@ -412,6 +413,7 @@ static struct attribute *bch_cached_dev_files[] = { &sysfs_writeback_rate_update_seconds, &sysfs_writeback_rate_i_term_inverse, &sysfs_writeback_rate_p_term_inverse, + &sysfs_writeback_rate_minimum, &sysfs_writeback_rate_debug, &sysfs_errors, &sysfs_io_error_limit,