diff mbox series

[15/28] blk-wbt: kill check for legacy queue type

Message ID 20181025211039.11559-16-axboe@kernel.dk (mailing list archive)
State New, archived
Headers show
Series blk-mq driver conversions and legacy path removal | expand

Commit Message

Jens Axboe Oct. 25, 2018, 9:10 p.m. UTC
Everything is blk-mq at this point, so it doesn't make any sense
to have this option available as it does nothing.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 block/Kconfig   | 6 ------
 block/blk-wbt.c | 3 +--
 2 files changed, 1 insertion(+), 8 deletions(-)

Comments

Hannes Reinecke Oct. 29, 2018, 6:59 a.m. UTC | #1
On 10/25/18 11:10 PM, Jens Axboe wrote:
> Everything is blk-mq at this point, so it doesn't make any sense
> to have this option available as it does nothing.
> 
> Signed-off-by: Jens Axboe <axboe@kernel.dk>
> ---
>   block/Kconfig   | 6 ------
>   block/blk-wbt.c | 3 +--
>   2 files changed, 1 insertion(+), 8 deletions(-)
> 
Reviewed-by: Hannes Reinecke <hare@suse.com>

Cheers,

Hannes
diff mbox series

Patch

diff --git a/block/Kconfig b/block/Kconfig
index f7045aa47edb..8044452a4fd3 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -155,12 +155,6 @@  config BLK_CGROUP_IOLATENCY
 
 	Note, this is an experimental interface and could be changed someday.
 
-config BLK_WBT_SQ
-	bool "Single queue writeback throttling"
-	depends on BLK_WBT
-	---help---
-	Enable writeback throttling by default on legacy single queue devices
-
 config BLK_WBT_MQ
 	bool "Multiqueue writeback throttling"
 	default y
diff --git a/block/blk-wbt.c b/block/blk-wbt.c
index 8ac93fcbaa2e..49fac89a981c 100644
--- a/block/blk-wbt.c
+++ b/block/blk-wbt.c
@@ -709,8 +709,7 @@  void wbt_enable_default(struct request_queue *q)
 	if (!test_bit(QUEUE_FLAG_REGISTERED, &q->queue_flags))
 		return;
 
-	if ((q->mq_ops && IS_ENABLED(CONFIG_BLK_WBT_MQ)) ||
-	    (q->request_fn && IS_ENABLED(CONFIG_BLK_WBT_SQ)))
+	if (IS_ENABLED(CONFIG_BLK_WBT_MQ))
 		wbt_init(q);
 }
 EXPORT_SYMBOL_GPL(wbt_enable_default);