From patchwork Thu Oct 25 21:10:16 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 10656495 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 90E9C15A7 for ; Thu, 25 Oct 2018 21:10:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 871CF2C648 for ; Thu, 25 Oct 2018 21:10:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7BF282C650; Thu, 25 Oct 2018 21:10:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3AD692C648 for ; Thu, 25 Oct 2018 21:10:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726386AbeJZFpO (ORCPT ); Fri, 26 Oct 2018 01:45:14 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:55765 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726291AbeJZFpN (ORCPT ); Fri, 26 Oct 2018 01:45:13 -0400 Received: by mail-it1-f196.google.com with SMTP id c23-v6so3333564itd.5 for ; Thu, 25 Oct 2018 14:10:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=H2DJe2MF+ITkX20eYsEgegbnJhVf5nQtlWVydNDogfU=; b=xAXWN3M0KpJz0O/FkeW9Ll+EBCg8in90F+Fy4F50+tyJisszPZt6q1TJEXLam9X7c2 j8yGldyEh5JATZ8Oy1GmPRPSvB4A+/1l/kcpgYoBN6ME70YMvB24UPCYhukpl7994Q2h kC3/lbTDDn/RggaXTvRpCu2ooYV9g1ET3SN3/HAWmX9KhQ47k6+EI/Npkz8IWuuDddM3 LpWaKCgfFAQ6x1F8WWyRJb1DaKfYF6GogjDMPdFXMk+c62drCbDyBMMEKNdjy2SJOpJR 1vfuLKaPpqmX3uZLMHawTUHVTTj2A7IspIDF5WzmsENePHRmMdmqaGjF9xvQ9yNrJ8+4 ptrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=H2DJe2MF+ITkX20eYsEgegbnJhVf5nQtlWVydNDogfU=; b=cJWQxozj0BsL/rU0U+7ZP80wTd/5O3oh63NhPfE9nOrzSoRoxFjsdFI6ScVOIDMItl 3BzLvaVaIbBT32kMz1Hvd+gGCVoq9taf7qgM5scY9Z3MyAC9uhPcAZgjlAH3Pd7H7JXg xYZN85MGJgSRCaFOP1ouSuvD3MZQU76Wm3UbwPhTeXFHMTH7fpDitFjrTL02r334yrdw YoQ9F0x14PDffxkdTNLIHUc0y20LQAW9Z8LsC+XfzdnZmLdKd4Ip8U6Mnar7DcPkByF8 UIdcfPSV/b7+/xxVdM7Q01jQLDU2hlAhWfJNM23Rb/TFWmBUo5tqfY97hS6aHT0GUYKQ 6hZA== X-Gm-Message-State: AGRZ1gLKkj15hAh4g11418gvOLBIFCLtfU92h++v8rFd2PV/5+GM0z9a r85Hs8Bd1ACHnIX0aRhui7qRQLWNmtTRDQ== X-Google-Smtp-Source: AJdET5fPojsDXD+yxqth5WVNBZyJi4uvmpWVfh9MLD6pbHGqspBZl5VlR+36+oki1TTC0sDjq4w24g== X-Received: by 2002:a24:c647:: with SMTP id j68-v6mr2164213itg.138.1540501854270; Thu, 25 Oct 2018 14:10:54 -0700 (PDT) Received: from localhost.localdomain ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id e65-v6sm3446375ioa.76.2018.10.25.14.10.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 25 Oct 2018 14:10:53 -0700 (PDT) From: Jens Axboe To: linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org Cc: Jens Axboe , Bart Van Assche , Parav Pandit Subject: [PATCH 05/28] IB/srp: remove old request_fn_active check Date: Thu, 25 Oct 2018 15:10:16 -0600 Message-Id: <20181025211039.11559-6-axboe@kernel.dk> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181025211039.11559-1-axboe@kernel.dk> References: <20181025211039.11559-1-axboe@kernel.dk> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This check is only viable for non scsi-mq. Since that is going away, kill this legacy check. Cc: Bart Van Assche Cc: Parav Pandit Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- drivers/infiniband/ulp/srp/ib_srp.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 0b34e909505f..5a79444c2f3c 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp/ib_srp.c @@ -1334,13 +1334,6 @@ static void srp_terminate_io(struct srp_rport *rport) struct scsi_device *sdev; int i, j; - /* - * Invoking srp_terminate_io() while srp_queuecommand() is running - * is not safe. Hence the warning statement below. - */ - shost_for_each_device(sdev, shost) - WARN_ON_ONCE(sdev->request_queue->request_fn_active); - for (i = 0; i < target->ch_count; i++) { ch = &target->ch[i];