From patchwork Wed Oct 31 17:59:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 10663059 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A924813A4 for ; Wed, 31 Oct 2018 17:59:49 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CACA2B4D5 for ; Wed, 31 Oct 2018 17:59:49 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 917002B4DD; Wed, 31 Oct 2018 17:59:49 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 338F52B4D5 for ; Wed, 31 Oct 2018 17:59:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729991AbeKAC6v (ORCPT ); Wed, 31 Oct 2018 22:58:51 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:50646 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730167AbeKAC6v (ORCPT ); Wed, 31 Oct 2018 22:58:51 -0400 Received: by mail-it1-f194.google.com with SMTP id k206-v6so19562926ite.0 for ; Wed, 31 Oct 2018 10:59:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=RRsIv6x9D0L5FZJ3lqvvZq/utL8gUTtS3lXk5sK5SY8=; b=Qe7A5DZRWSzwwzRJ8E1uOeDzJTKQNENXKkgJy08mHoeJ7eYBlSrSE9chYSWGy6Beel JXOleeER3sEq9uzscYV8MFG1jvlsEtkzC5vz5Mm5hB/bTn1/9kpIMXObSGbn3K2JkHTg Y1qPf08Fwfo8URkmhj5VSpw7YiXRhFludP/ogDFmldU0fFZL2FiwUWPVUBDyCpM0HIGH 11AW+i2+E5cN5U4dj8yGyxCkfez6Cb1X8aztWkEtyXeAsC+NHKI6GAQWHXKOtDCKeWpH cYICA7HxZnTRnv6H+Gxqq+x79F1MZwNSFfous8za9kJFZ5idPEB2EznTd909pYvqUECH CC0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=RRsIv6x9D0L5FZJ3lqvvZq/utL8gUTtS3lXk5sK5SY8=; b=gVzGiJjeCDQqHbI8qcDqBAeEghUbPZbj8ZbYX7srqIzNf8EsFgngvS0wJysFwT4yHV LWfF5MlVXOVO8ciAQjBXaBpMWZgE+IESIwn3mnULco+WyL06yyS3wxobuMAiCqjUq4MI Ci1mYIq+a8eNBOMYjZI4KGxuEd5Bu0ifsq7w425BrYXeeY0J8BT+KDOij9mx6su+XftN vaxUA42iB3IeC7G+lCfupOflePzmc11IWwOi6SX14+8sBwo1DQ6IEIpGLKOPILIr799B h8wa++ofOZmPL4WHxMtxwaWGsh2TRbIDqNGlukBN4Zey3mWqZjB8laySXKNk+IFl/ltk ZjkA== X-Gm-Message-State: AGRZ1gJDySIMzrNm5Dd2TH40wM2QGk3GYHVJvx/QTwzl8pZ0nMh4rLlN sLkC4WgGE7TpNnlu3CWrMmatP/FjB00= X-Google-Smtp-Source: AJdET5fr3x+wwoAItABYe04LXxkFEUrj45oUxEFtgP6W4taNUS0CUx/5nbQBofVPM4mNjQfIRl1NGQ== X-Received: by 2002:a05:660c:a54:: with SMTP id j20mr3267787itl.43.1541008786500; Wed, 31 Oct 2018 10:59:46 -0700 (PDT) Received: from localhost.localdomain ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id 197-v6sm10982947iou.87.2018.10.31.10.59.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Oct 2018 10:59:45 -0700 (PDT) From: Jens Axboe To: linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org Cc: Jens Axboe Subject: [PATCH 10/30] block: remove q->lld_busy_fn() Date: Wed, 31 Oct 2018 11:59:02 -0600 Message-Id: <20181031175922.8849-11-axboe@kernel.dk> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181031175922.8849-1-axboe@kernel.dk> References: <20181031175922.8849-1-axboe@kernel.dk> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Nobody is using the legacy path for blk_lld_busy() anymore, remove it. Reviewed-by: Hannes Reinecke Signed-off-by: Jens Axboe --- block/blk-core.c | 2 -- block/blk-settings.c | 6 ------ include/linux/blkdev.h | 3 --- 3 files changed, 11 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index c99088d0e80b..5044a1c41493 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -3427,8 +3427,6 @@ EXPORT_SYMBOL_GPL(rq_flush_dcache_pages); */ int blk_lld_busy(struct request_queue *q) { - if (q->lld_busy_fn) - return q->lld_busy_fn(q); if (q->mq_ops && q->mq_ops->busy) return q->mq_ops->busy(q); diff --git a/block/blk-settings.c b/block/blk-settings.c index ffd459969689..82b31fb2888c 100644 --- a/block/blk-settings.c +++ b/block/blk-settings.c @@ -73,12 +73,6 @@ void blk_queue_rq_timed_out(struct request_queue *q, rq_timed_out_fn *fn) } EXPORT_SYMBOL_GPL(blk_queue_rq_timed_out); -void blk_queue_lld_busy(struct request_queue *q, lld_busy_fn *fn) -{ - q->lld_busy_fn = fn; -} -EXPORT_SYMBOL_GPL(blk_queue_lld_busy); - /** * blk_set_default_limits - reset limits to default values * @lim: the queue_limits structure to reset diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 4293dc1cd160..e867733b761d 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -320,7 +320,6 @@ typedef void (unprep_rq_fn) (struct request_queue *, struct request *); struct bio_vec; typedef void (softirq_done_fn)(struct request *); typedef int (dma_drain_needed_fn)(struct request *); -typedef int (lld_busy_fn) (struct request_queue *q); typedef int (bsg_job_fn) (struct bsg_job *); typedef int (init_rq_fn)(struct request_queue *, struct request *, gfp_t); typedef void (exit_rq_fn)(struct request_queue *, struct request *); @@ -466,7 +465,6 @@ struct request_queue { softirq_done_fn *softirq_done_fn; rq_timed_out_fn *rq_timed_out_fn; dma_drain_needed_fn *dma_drain_needed; - lld_busy_fn *lld_busy_fn; /* Called just after a request is allocated */ init_rq_fn *init_rq_fn; /* Called just before a request is freed */ @@ -1255,7 +1253,6 @@ extern void blk_queue_update_dma_pad(struct request_queue *, unsigned int); extern int blk_queue_dma_drain(struct request_queue *q, dma_drain_needed_fn *dma_drain_needed, void *buf, unsigned int size); -extern void blk_queue_lld_busy(struct request_queue *q, lld_busy_fn *fn); extern void blk_queue_segment_boundary(struct request_queue *, unsigned long); extern void blk_queue_virt_boundary(struct request_queue *, unsigned long); extern void blk_queue_prep_rq(struct request_queue *, prep_rq_fn *pfn);