From patchwork Wed Oct 31 17:59:08 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 10663089 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C14EF3CF1 for ; Wed, 31 Oct 2018 18:00:00 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B3B0E2B4D5 for ; Wed, 31 Oct 2018 18:00:00 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A7AEB2B4E4; Wed, 31 Oct 2018 18:00:00 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 608652B4D5 for ; Wed, 31 Oct 2018 18:00:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730064AbeKAC7C (ORCPT ); Wed, 31 Oct 2018 22:59:02 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:39752 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730063AbeKAC7C (ORCPT ); Wed, 31 Oct 2018 22:59:02 -0400 Received: by mail-io1-f65.google.com with SMTP id n11-v6so10349116iob.6 for ; Wed, 31 Oct 2018 10:59:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Oc7vc+QOBEZDLRdp/nP+eTB+4epQrRfeqnCYEaksMMI=; b=ZvRU8VZbcjn8hiFaBHxsb9E7PRggpW5gsJ5e0myOuaLSCNo1dEDkORemZ0NanXIOtM px7KcrvBTps26RmWE0G3LbAfm1ELUfKDJKh5zLcgQqynVPodFpVZBNUSjc63UhRgb0As UyNT23Ah8JzSY/5BHF+icmdQP1pSjz1Z5Mp3rdh8fmKQ4PQnwfaqwrlZ16ZhJs2cbwEP +JaTzdeVDv/wgnhIAgRctIaymGgybYfTa5aPGgZws3M/RdCtb3ywAC0wVl4gBW//COKQ DTIqa3LBMD3+uJtgZVIMYgsIIX4GrhCLGmXqfCi6Mc0ogo8ISY39Y3OWgahqMwLps6EF EezA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Oc7vc+QOBEZDLRdp/nP+eTB+4epQrRfeqnCYEaksMMI=; b=hDVE8bW2GQ0f1YV7nyQdo/lQHJRuE92QNJo71pkA5e0FG3aEMkh8y4zF1m9/kCF8Wl MDZdtd9QXxkx2k4y5X2lXSPcnuA843ydzlnsTrLxVwQ9uxwqmshvYsFl4k6g7inzgSoe TKY6COAvFDT3UhxWF4RsTNWRR75XreerR/PbwxZFJuR7sMFZ+20pN0Y5JIz3oJ4tOPjR SUYjcLSyvkUjg89iPuDAlnQ4D37HLxRrr2aPhfJiM3EB52L8BnDOaVtnnAGAcklm7Fo+ XYgdx2QE1zfwxIZkFMh3NUV4QejVCLRWWC5BM4TOyaJpH4MOx9oU0vXh0ZILgkqmb4Xm ITvA== X-Gm-Message-State: AGRZ1gK0jKMV/+Ud6SPl8Vzftaq4tMxm8u2230eNM67s8jNPwsWnZQt5 vu5XSIxju9BEdmkmAOjGnKJqLjCWBGk= X-Google-Smtp-Source: AJdET5fzJLaAGXM5cjZCkL1um7gwI0V1xGHgC8Htd+OGlMr35XFInMhWsyQDn/5sIJdSSHxMdt+2aQ== X-Received: by 2002:a6b:14d8:: with SMTP id 207-v6mr2853508iou.103.1541008797845; Wed, 31 Oct 2018 10:59:57 -0700 (PDT) Received: from localhost.localdomain ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id 197-v6sm10982947iou.87.2018.10.31.10.59.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 31 Oct 2018 10:59:56 -0700 (PDT) From: Jens Axboe To: linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org Cc: Jens Axboe Subject: [PATCH 16/30] blk-wbt: kill check for legacy queue type Date: Wed, 31 Oct 2018 11:59:08 -0600 Message-Id: <20181031175922.8849-17-axboe@kernel.dk> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181031175922.8849-1-axboe@kernel.dk> References: <20181031175922.8849-1-axboe@kernel.dk> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Everything is blk-mq at this point, so it doesn't make any sense to have this option available as it does nothing. Reviewed-by: Hannes Reinecke Signed-off-by: Jens Axboe --- block/Kconfig | 6 ------ block/blk-wbt.c | 3 +-- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/block/Kconfig b/block/Kconfig index f7045aa47edb..8044452a4fd3 100644 --- a/block/Kconfig +++ b/block/Kconfig @@ -155,12 +155,6 @@ config BLK_CGROUP_IOLATENCY Note, this is an experimental interface and could be changed someday. -config BLK_WBT_SQ - bool "Single queue writeback throttling" - depends on BLK_WBT - ---help--- - Enable writeback throttling by default on legacy single queue devices - config BLK_WBT_MQ bool "Multiqueue writeback throttling" default y diff --git a/block/blk-wbt.c b/block/blk-wbt.c index 8ac93fcbaa2e..0fc222d4194b 100644 --- a/block/blk-wbt.c +++ b/block/blk-wbt.c @@ -709,8 +709,7 @@ void wbt_enable_default(struct request_queue *q) if (!test_bit(QUEUE_FLAG_REGISTERED, &q->queue_flags)) return; - if ((q->mq_ops && IS_ENABLED(CONFIG_BLK_WBT_MQ)) || - (q->request_fn && IS_ENABLED(CONFIG_BLK_WBT_SQ))) + if (q->mq_ops && IS_ENABLED(CONFIG_BLK_WBT_MQ)) wbt_init(q); } EXPORT_SYMBOL_GPL(wbt_enable_default);