From patchwork Thu Nov 8 16:06:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jens Axboe X-Patchwork-Id: 10674559 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A94FB15E9 for ; Thu, 8 Nov 2018 16:06:17 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9A89D2DC32 for ; Thu, 8 Nov 2018 16:06:17 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8F2002DC51; Thu, 8 Nov 2018 16:06:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 347D02DC32 for ; Thu, 8 Nov 2018 16:06:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727369AbeKIBm0 (ORCPT ); Thu, 8 Nov 2018 20:42:26 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:40364 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726700AbeKIBmZ (ORCPT ); Thu, 8 Nov 2018 20:42:25 -0500 Received: by mail-io1-f67.google.com with SMTP id a23-v6so15006674iod.7 for ; Thu, 08 Nov 2018 08:06:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Vjsnj4iye7Yy9ynWuvMBYnZa5W68EXsl0YHGdK8STFU=; b=mSCo8oYND1vfcfj+tnS2ZnjvhzNEerQfhurGCs25EjlfLTFxOS89Nxs/ag77b0axVj +ftGVpCRfzAquSh06r3sk6H7/EH8hHfHCnpM9HIliPcXDm5udBxpUZ53E5C1rWAbPojc X4Ujz/yWm3bQHhi/z7itd38r8f1wWiHUKF3SzsgZgEUdB/REubzJlVXIOLlbJoleMDNP EzLzDBT6nsuazRnsW34J96s0jBMB6wkZi2RmtsRev7WZlweYRQ/MAyMb6VkXT4siBwmb AvVBwan9LsKH0lRUxfIHeUhfgXCBLQgRH4xt+NNCdmGto/SY77dTg5A8gQuzDHOCJ5EW efHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Vjsnj4iye7Yy9ynWuvMBYnZa5W68EXsl0YHGdK8STFU=; b=EXYT4q5pRX20Pzz4EGwT4D/pcJRMG3WccwwWTNm2swFDzNe9D96GmeC/SkLVAcjKwV HGDUrwZ8tXiI+vZjU2NkE1KpKbgn+Qbc7k8tEIMyviEbLdP/FmgsjKd49PCIvvRveLSB E4xyyt9Go51IVMzbI/wsMvbioZYDHxCP7g52akBtTrZf1ksxn8tUD+fOYDs4gME5Xuwg YQekj3ABfmc0cQyJHAsw9AX2vnr9ee+5Qy4Xa2OY7TwifB5+HG/QdggB9BzfuDMbHGu9 8UgKaIfaj7xkcIWM5Gyi+mDiBE1tFCqp2+rPAhKWGtIp7BycyrkMovxz+igEuYO4vfM1 ckhg== X-Gm-Message-State: AGRZ1gKhLnp/LxaA3oRGSa2IUn/ZQwcTg04PgI5POSOxsd7OUYR1Y+ce uHZRqSJ56hpDsWNx1HNyMqH1IhYf220= X-Google-Smtp-Source: AJdET5cv48aZASVHsb8nshzVSNGZ8W6mt/luKx/sEcElXMtNY3Zkoc1K+rkQBR6raRGmRAiRQ8SiJQ== X-Received: by 2002:a6b:3b14:: with SMTP id i20-v6mr4241787ioa.13.1541693175180; Thu, 08 Nov 2018 08:06:15 -0800 (PST) Received: from x1.thefacebook.com ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id g8-v6sm1821959iof.11.2018.11.08.08.06.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 08 Nov 2018 08:06:14 -0800 (PST) From: Jens Axboe To: linux-block@vger.kernel.org Cc: Jens Axboe , Mike Snitzer Subject: [PATCH] blk-mq: provide a helper to check if a queue is busy Date: Thu, 8 Nov 2018 09:06:07 -0700 Message-Id: <20181108160609.27568-2-axboe@kernel.dk> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181108160609.27568-1-axboe@kernel.dk> References: <20181108160609.27568-1-axboe@kernel.dk> Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Returns true if the queue currently has requests pending, false if not. DM can use this to replace the atomic_inc/dec they do per device to see if a device is busy. Cc: Mike Snitzer Signed-off-by: Jens Axboe --- block/blk-mq.c | 22 ++++++++++++++++++++++ include/linux/blk-mq.h | 2 ++ 2 files changed, 24 insertions(+) diff --git a/block/blk-mq.c b/block/blk-mq.c index 4a622c832b31..848adcc51c43 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -790,6 +790,28 @@ struct request *blk_mq_tag_to_rq(struct blk_mq_tags *tags, unsigned int tag) } EXPORT_SYMBOL(blk_mq_tag_to_rq); +static bool blk_mq_check_busy(struct blk_mq_hw_ctx *hctx, struct request *rq, + void *priv, bool reserved) +{ + bool *busy = (bool *) priv; + + /* + * If we find a request, we know the queue is busy. Return false + * to stop the iteration. + */ + *busy = true; + return false; +} + +bool blk_mq_queue_busy(struct request_queue *q) +{ + bool busy = false; + + blk_mq_queue_tag_busy_iter(q, blk_mq_check_busy, &busy); + return busy; +} +EXPORT_SYMBOL_GPL(blk_mq_queue_busy); + static void blk_mq_rq_timed_out(struct request *req, bool reserved) { req->rq_flags |= RQF_TIMED_OUT; diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h index ff497dfcbbf9..929e8abc5535 100644 --- a/include/linux/blk-mq.h +++ b/include/linux/blk-mq.h @@ -250,6 +250,8 @@ void blk_mq_flush_plug_list(struct blk_plug *plug, bool from_schedule); void blk_mq_free_request(struct request *rq); bool blk_mq_can_queue(struct blk_mq_hw_ctx *); +bool blk_mq_queue_busy(struct request_queue *q); + enum { /* return when out of requests */ BLK_MQ_REQ_NOWAIT = (__force blk_mq_req_flags_t)(1 << 0),