[nvme-cli,v3,15/13] nvme: Add TCP transport

Commit Message

Sagi Grimberg Nov. 22, 2018, 1:56 a.m. UTC

From: Sagi Grimberg <[e-mail]>

Signed-off-by: Sagi Grimberg <[e-mail]>
---
 fabrics.c    | 2 ++
 linux/nvme.h | 1 +
 2 files changed, 3 insertions(+)

Comments

Keith Busch Nov. 26, 2018, 3:47 p.m. UTC | #1

The cli parts good to me. Is there any forseeable issue if I apply these
ahead of the kernel integration? I don't see any, but just want to
confirm since its all in one series.

Sagi Grimberg Nov. 27, 2018, 7:45 a.m. UTC | #2

> The cli parts good to me. Is there any forseeable issue if I apply these
> ahead of the kernel integration? I don't see any, but just want to
> confirm since its all in one series.

I don't see an issue, note that its on top of the sqflow patch [1]
that I've been meaning to ping you on.

[PATCH nvme-cli 5/4 v4] fabrics: support fabrics sq flow control disable
from series: Support SQ flow control disabled mode (TP 8005)

Patch

diff --git a/fabrics.c b/fabrics.c
index e7c2021b0c70..86f6f992b14f 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -95,6 +95,7 @@  static const char *arg_str(const char * const *strings,
 static const char * const trtypes[] = {
 	[NVMF_TRTYPE_RDMA]	= "rdma",
 	[NVMF_TRTYPE_FC]	= "fibre-channel",
+	[NVMF_TRTYPE_TCP]	= "tcp",
 	[NVMF_TRTYPE_LOOP]	= "loop",
 };
 
@@ -696,6 +697,7 @@  retry:
 
 	switch (e->trtype) {
 	case NVMF_TRTYPE_RDMA:
+	case NVMF_TRTYPE_TCP:
 		switch (e->adrfam) {
 		case NVMF_ADDR_FAMILY_IP4:
 		case NVMF_ADDR_FAMILY_IP6:
diff --git a/linux/nvme.h b/linux/nvme.h
index a6a44b066267..7a600c791877 100644
--- a/linux/nvme.h
+++ b/linux/nvme.h
@@ -52,6 +52,7 @@  enum {
 enum {
 	NVMF_TRTYPE_RDMA	= 1,	/* RDMA */
 	NVMF_TRTYPE_FC		= 2,	/* Fibre Channel */
+	NVMF_TRTYPE_TCP		= 3,	/* TCP */
 	NVMF_TRTYPE_LOOP	= 254,	/* Reserved for host usage */
 	NVMF_TRTYPE_MAX,
 };