diff mbox series

[3/6] nvme: remove opportunistic polling from bdev target

Message ID 20181123183411.8708-4-axboe@kernel.dk (mailing list archive)
State New, archived
Headers show
Series Various block optimizations | expand

Commit Message

Jens Axboe Nov. 23, 2018, 6:34 p.m. UTC 
It doesn't set HIPRI on the bio, so polling for it is pretty silly.

Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
 drivers/nvme/target/io-cmd-bdev.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Christoph Hellwig Nov. 26, 2018, 8:17 a.m. UTC | #1 
On Fri, Nov 23, 2018 at 11:34:08AM -0700, Jens Axboe wrote:
> It doesn't set HIPRI on the bio, so polling for it is pretty silly.
> 
> Signed-off-by: Jens Axboe <axboe@kernel.dk>

Well, I know who forgot to mark it hipri :)

But for now this looks good, we need to revisit fabrics polling entirely
once everything has settled.

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/drivers/nvme/target/io-cmd-bdev.c b/drivers/nvme/target/io-cmd-bdev.c
index c1ec3475a140..c1cb2ed5531c 100644
--- a/drivers/nvme/target/io-cmd-bdev.c
+++ b/drivers/nvme/target/io-cmd-bdev.c
@@ -115,8 +115,6 @@  static void nvmet_bdev_execute_rw(struct nvmet_req *req)
 	}
 
 	cookie = submit_bio(bio);
-
-	blk_poll(bdev_get_queue(req->ns->bdev), cookie);
 }
 
 static void nvmet_bdev_execute_flush(struct nvmet_req *req)