diff mbox series

[blktests,02/14] common: Introduce _test_dev_is_zoned() helper function

Message ID 20190109013542.23686-3-damien.lemoal@wdc.com (mailing list archive)
State New, archived
Headers show
Series Implement zoned block device support | expand

Commit Message

Damien Le Moal Jan. 9, 2019, 1:35 a.m. UTC 
From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>

Introduce the helper function _test_dev_is_zoned() to check if a test
device is a zoned block device. Using this function, test scripts can
adjust test conditions based on the device zone model.
This function can also be used within test scripts implementation of the
device_requires() function to ensure that the test is run only for zoned
block device or only for non-zoned block device.

Signed-off-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
---
 common/rc | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Johannes Thumshirn Jan. 9, 2019, 8:46 a.m. UTC | #1 
On 09/01/2019 02:35, Damien Le Moal wrote:
> From: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
> +_test_dev_is_zoned() {
> +	local zoned_file="${TEST_DEV_SYSFS}/queue/zoned"
> +	if grep -q -e "none" "${zoned_file}" ; then

Nit: I think we can leave the zoned_file variable out
	if grep -qe "none" "${TEST_DEV_SYSFS}/queue/zoned"; then
	[...]
works as well and is a bit more descriptive
diff mbox series

Patch

diff --git a/common/rc b/common/rc
index 153a323..999590d 100644
--- a/common/rc
+++ b/common/rc
@@ -214,3 +214,12 @@  _test_dev_in_hotplug_slot() {
 _filter_xfs_io_error() {
 	sed -e 's/^\(.*\)64\(: .*$\)/\1\2/'
 }
+
+_test_dev_is_zoned() {
+	local zoned_file="${TEST_DEV_SYSFS}/queue/zoned"
+	if grep -q -e "none" "${zoned_file}" ; then
+		SKIP_REASON="${TEST_DEV} is not a zoned block device"
+		return 1
+	fi
+	return 0
+}