From patchwork Tue Mar 5 03:33:19 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi Zhang X-Patchwork-Id: 10838887 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EF90D1515 for ; Tue, 5 Mar 2019 03:33:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DD9922BDE5 for ; Tue, 5 Mar 2019 03:33:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D1B5A2BDE8; Tue, 5 Mar 2019 03:33:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 919F32BDCA for ; Tue, 5 Mar 2019 03:33:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726934AbfCEDdd (ORCPT ); Mon, 4 Mar 2019 22:33:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38298 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726522AbfCEDdc (ORCPT ); Mon, 4 Mar 2019 22:33:32 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9617B4E908; Tue, 5 Mar 2019 03:33:32 +0000 (UTC) Received: from dhcp-12-135.nay.redhat.com (dhcp-12-135.nay.redhat.com [10.66.12.135]) by smtp.corp.redhat.com (Postfix) with ESMTP id 120415DD63; Tue, 5 Mar 2019 03:33:30 +0000 (UTC) From: Yi Zhang To: osandov@fb.com Cc: linux-block@vger.kernel.org, shinichiro.kawasaki@wdc.com Subject: [PATCH blktests] Fix the failure case which will exit with 0 Date: Tue, 5 Mar 2019 11:33:19 +0800 Message-Id: <20190305033319.6825-1-yi.zhang@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 05 Mar 2019 03:33:32 +0000 (UTC) Sender: linux-block-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The return value of a failing test was masked by the zoned test check. Make sure to return either the original or zoned run failed value. Fixes: e840e15 ("config: Introduce RUN_ZONED_TESTS variable and CAN_BE_ZONED flag") Signed-off-by: Yi Zhang Reviewed-by: Shin'ichiro Kawasaki --- check | 3 +++ 1 file changed, 3 insertions(+) diff --git a/check b/check index 819d8f3..c65270e 100755 --- a/check +++ b/check @@ -431,11 +431,14 @@ _run_test() { RESULTS_DIR="$OUTPUT/nodev" _call_test test + local ret=$? if (( RUN_ZONED_TESTS && CAN_BE_ZONED )); then RESULTS_DIR="$OUTPUT/nodev_zoned" RUN_FOR_ZONED=1 _call_test test + ret=$(( ret || $? )) fi + return $ret else if [[ ${#TEST_DEVS[@]} -eq 0 ]] && \ declare -fF fallback_device >/dev/null; then