| Message ID | 20190313070511.8283-1-xiliang@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [blktests] Fix checking multiple modules error in _have_modules() | expand |
On Wed, Mar 13, 2019 at 03:05:11PM +0800, Xiao Liang wrote: Applied, thanks! > Signed-off-by: Xiao Liang <xiliang@redhat.com> > --- > common/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/rc b/common/rc > index 0c354a2..71e27c3 100644 > --- a/common/rc > +++ b/common/rc > @@ -33,7 +33,7 @@ _have_modules() { > local module > > for module in "$@"; do > - if ! modprobe -n -q "$1"; then > + if ! modprobe -n -q "$module"; then > missing+=("$module") > fi > done > -- > 2.17.2 >
Looks good. Reviewed-by : Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> On 3/13/19 12:05 AM, Xiao Liang wrote: > Signed-off-by: Xiao Liang <xiliang@redhat.com> > --- > common/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/rc b/common/rc > index 0c354a2..71e27c3 100644 > --- a/common/rc > +++ b/common/rc > @@ -33,7 +33,7 @@ _have_modules() { > local module > > for module in "$@"; do > - if ! modprobe -n -q "$1"; then > + if ! modprobe -n -q "$module"; then > missing+=("$module") > fi > done >
diff --git a/common/rc b/common/rc index 0c354a2..71e27c3 100644 --- a/common/rc +++ b/common/rc @@ -33,7 +33,7 @@ _have_modules() { local module for module in "$@"; do - if ! modprobe -n -q "$1"; then + if ! modprobe -n -q "$module"; then missing+=("$module") fi done
Signed-off-by: Xiao Liang <xiliang@redhat.com> --- common/rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)