[GIT,PULL,01/26] lightnvm: pblk: line reference fix in GC

Message ID	20190504183811.18725-2-mb@lightnvm.io (mailing list archive)
State	New, archived
Headers	show Return-Path: <linux-block-owner@kernel.org> From: =?utf-8?q?Matias_Bj=C3=B8rling?= <mb@lightnvm.io> To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Igor Konopko <igor.j.konopko@intel.com>, =?utf-8?q?Matias_Bj=C3=B8rling?= <mb@lightnvm.io> Subject: [GIT PULL 01/26] lightnvm: pblk: line reference fix in GC Date: Sat, 4 May 2019 20:37:46 +0200 Message-Id: <20190504183811.18725-2-mb@lightnvm.io> In-Reply-To: <20190504183811.18725-1-mb@lightnvm.io> References: <20190504183811.18725-1-mb@lightnvm.io> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-block-owner@vger.kernel.org Precedence: bulk
Series	lightnvm updates for 5.2 \| expand [GIT,PULL,00/26] lightnvm updates for 5.2 [GIT,PULL,01/26] lightnvm: pblk: line reference fix in GC [GIT,PULL,02/26] lightnvm: pblk: rollback on error during gc read [GIT,PULL,03/26] lightnvm: pblk: reduce L2P memory footprint [GIT,PULL,04/26] lightnvm: pblk: remove unused smeta_ssec field [GIT,PULL,05/26] lightnvm: pblk: gracefully handle GC vmalloc fail [GIT,PULL,06/26] lightnvm: pblk: fix race during put line [GIT,PULL,07/26] lightnvm: pblk: ensure that erase is chunk aligned [GIT,PULL,08/26] lightnvm: pblk: cleanly fail when there is not enough memory [GIT,PULL,09/26] lightnvm: pblk: set proper read status in bio [GIT,PULL,10/26] lightnvm: Inherit mdts from the parent nvme device [GIT,PULL,11/26] lightnvm: pblk: fix bio leak when bio is split [GIT,PULL,12/26] lightnvm: pblk: set propper line as data_line after gc [GIT,PULL,13/26] lightnvm: prevent race condition on pblk remove [GIT,PULL,14/26] lightnvm: pblk: fix lock order in pblk_rb_tear_down_check [GIT,PULL,15/26] lightnvm: pblk: kick writer on write recovery path [GIT,PULL,16/26] lightnvm: pblk: fix update line wp in OOB recovery [GIT,PULL,17/26] lightnvm: pblk: propagate errors when reading meta [GIT,PULL,18/26] lightnvm: pblk: wait for inflight IOs in recovery [GIT,PULL,19/26] lightnvm: pblk: remove internal IO timeout [GIT,PULL,20/26] lightnvm: pblk: GC error handling [GIT,PULL,21/26] lightnvm: pblk: IO path reorganization [GIT,PULL,22/26] lightnvm: pblk: recover only written metadata [GIT,PULL,23/26] lightnvm: track inflight target creations [GIT,PULL,24/26] lightnvm: do not remove instance under global lock [GIT,PULL,25/26] lightnvm: pblk: simplify partial read path [GIT,PULL,26/26] lightnvm: pblk: use nvm_rq_to_ppa_list()

Message ID

20190504183811.18725-2-mb@lightnvm.io (mailing list archive)

State

New, archived

Headers

From: =?utf-8?q?Matias_Bj=C3=B8rling?= <mb@lightnvm.io>
To: axboe@fb.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
 Igor Konopko <igor.j.konopko@intel.com>,
 =?utf-8?q?Matias_Bj=C3=B8rling?= <mb@lightnvm.io>
Subject: [GIT PULL 01/26] lightnvm: pblk: line reference fix in GC
Date: Sat,  4 May 2019 20:37:46 +0200
Message-Id: <20190504183811.18725-2-mb@lightnvm.io>
In-Reply-To: <20190504183811.18725-1-mb@lightnvm.io>
References: <20190504183811.18725-1-mb@lightnvm.io>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: linux-block-owner@vger.kernel.org
Precedence: bulk

Series

lightnvm updates for 5.2 | expand

Commit Message

Matias Bjorling May 4, 2019, 6:37 p.m. UTC

From: Igor Konopko <igor.j.konopko@intel.com>

Fixes the GC error case when moving a line back to closed state
while releasing additional references.

Signed-off-by: Igor Konopko <igor.j.konopko@intel.com>
Reviewed-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
Reviewed-by: Javier González <javier@javigon.com>
Signed-off-by: Matias Bjørling <mb@lightnvm.io>
---
 drivers/lightnvm/pblk-gc.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c
index 26a52ea7ec45..901e49951ab5 100644
--- a/drivers/lightnvm/pblk-gc.c
+++ b/drivers/lightnvm/pblk-gc.c
@@ -290,8 +290,11 @@  static void pblk_gc_line_prepare_ws(struct work_struct *work)
 fail_free_ws:
 	kfree(line_ws);
 
+	/* Line goes back to closed state, so we cannot release additional
+	 * reference for line, since we do that only when we want to do
+	 * gc to free line state transition.
+	 */
 	pblk_put_line_back(pblk, line);
-	kref_put(&line->ref, pblk_line_put);
 	atomic_dec(&gc->read_inflight_gc);
 
 	pblk_err(pblk, "failed to GC line %d\n", line->id);

[GIT,PULL,01/26] lightnvm: pblk: line reference fix in GC

Commit Message

Patch