| Message ID | 20190531000053.64053-4-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Improve block layer function documentation | expand |
Looks good. Reviewed-by: Chaitanya Kulkarni <chiatanya.kulkarni@wdc.com> On 5/30/19 5:01 PM, Bart Van Assche wrote: > Commit e99e88a9d2b0 renamed a function argument without updating the > corresponding kernel-doc header. Update the kernel-doc header. > > Cc: Kees Cook <keescook@chromium.org> > Fixes: e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()") # v4.15. > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > block/blk-throttle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-throttle.c b/block/blk-throttle.c > index 1b97a73d2fb1..9ea7c0ecad10 100644 > --- a/block/blk-throttle.c > +++ b/block/blk-throttle.c > @@ -1220,7 +1220,7 @@ static bool throtl_can_upgrade(struct throtl_data *td, > struct throtl_grp *this_tg); > /** > * throtl_pending_timer_fn - timer function for service_queue->pending_timer > - * @arg: the throtl_service_queue being serviced > + * @t: the pending_timer member of the throtl_service_queue being serviced > * > * This timer is armed when a child throtl_grp with active bio's become > * pending and queued on the service_queue's pending_tree and expires when >
On Thu, May 30, 2019 at 05:00:48PM -0700, Bart Van Assche wrote: > Commit e99e88a9d2b0 renamed a function argument without updating the > corresponding kernel-doc header. Update the kernel-doc header. > > Cc: Kees Cook <keescook@chromium.org> > Fixes: e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()") # v4.15. > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Kees Cook <keescook@chromium.org> -Kees > --- > block/blk-throttle.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/blk-throttle.c b/block/blk-throttle.c > index 1b97a73d2fb1..9ea7c0ecad10 100644 > --- a/block/blk-throttle.c > +++ b/block/blk-throttle.c > @@ -1220,7 +1220,7 @@ static bool throtl_can_upgrade(struct throtl_data *td, > struct throtl_grp *this_tg); > /** > * throtl_pending_timer_fn - timer function for service_queue->pending_timer > - * @arg: the throtl_service_queue being serviced > + * @t: the pending_timer member of the throtl_service_queue being serviced > * > * This timer is armed when a child throtl_grp with active bio's become > * pending and queued on the service_queue's pending_tree and expires when > -- > 2.22.0.rc1 >
diff --git a/block/blk-throttle.c b/block/blk-throttle.c index 1b97a73d2fb1..9ea7c0ecad10 100644 --- a/block/blk-throttle.c +++ b/block/blk-throttle.c @@ -1220,7 +1220,7 @@ static bool throtl_can_upgrade(struct throtl_data *td, struct throtl_grp *this_tg); /** * throtl_pending_timer_fn - timer function for service_queue->pending_timer - * @arg: the throtl_service_queue being serviced + * @t: the pending_timer member of the throtl_service_queue being serviced * * This timer is armed when a child throtl_grp with active bio's become * pending and queued on the service_queue's pending_tree and expires when
Commit e99e88a9d2b0 renamed a function argument without updating the corresponding kernel-doc header. Update the kernel-doc header. Cc: Kees Cook <keescook@chromium.org> Fixes: e99e88a9d2b0 ("treewide: setup_timer() -> timer_setup()") # v4.15. Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- block/blk-throttle.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)