Message ID | 20190531022801.10003-5-ming.lei@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | blk-mq/scsi: convert private reply queue into blk_mq hw queue | expand |
On 5/31/19 4:27 AM, Ming Lei wrote: > The 'host_tagset' can be set on scsi_debug device for testing > shared hostwide tags on multiple blk-mq hw queue. > > Signed-off-by: Ming Lei <ming.lei@redhat.com> > --- > drivers/scsi/scsi_debug.c | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
On 19-05-31 10:27:56, Ming Lei wrote: > The 'host_tagset' can be set on scsi_debug device for testing > shared hostwide tags on multiple blk-mq hw queue. > > Signed-off-by: Ming Lei <ming.lei@redhat.com> > --- > drivers/scsi/scsi_debug.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c > index d323523f5f9d..8cf3f6c3f4f9 100644 > --- a/drivers/scsi/scsi_debug.c > +++ b/drivers/scsi/scsi_debug.c > @@ -665,6 +665,7 @@ static bool have_dif_prot; > static bool write_since_sync; > static bool sdebug_statistics = DEF_STATISTICS; > static bool sdebug_wp; > +static bool sdebug_host_tagset = false; Hi Ming, I think we can leave it without an initialisation just like the others above. > > static unsigned int sdebug_store_sectors; > static sector_t sdebug_capacity; /* in sectors */ > @@ -4468,6 +4469,7 @@ module_param_named(vpd_use_hostno, sdebug_vpd_use_hostno, int, > module_param_named(wp, sdebug_wp, bool, S_IRUGO | S_IWUSR); > module_param_named(write_same_length, sdebug_write_same_length, int, > S_IRUGO | S_IWUSR); > +module_param_named(host_tagset, sdebug_host_tagset, bool, S_IRUGO | S_IWUSR); > > MODULE_AUTHOR("Eric Youngdale + Douglas Gilbert"); > MODULE_DESCRIPTION("SCSI debug adapter driver"); > @@ -5779,6 +5781,7 @@ static int sdebug_driver_probe(struct device *dev) > sdbg_host = to_sdebug_host(dev); > > sdebug_driver_template.can_queue = sdebug_max_queue; > + sdebug_driver_template.host_tagset = sdebug_host_tagset; > if (!sdebug_clustering) > sdebug_driver_template.dma_boundary = PAGE_SIZE - 1; Otherwise: It looks good to me in host tagset point of view. Reviewed-by: Minwoo Im <minwoo.im.dev@gmail.com>
On 2019-05-30 10:27 p.m., Ming Lei wrote: > The 'host_tagset' can be set on scsi_debug device for testing > shared hostwide tags on multiple blk-mq hw queue. > > Signed-off-by: Ming Lei <ming.lei@redhat.com> Hi, Attached are my suggestions to clean up this patch a bit. It basically - drops the unneeded initialization (pointed out in another review) - places new module_param_named() in alphabetical order - adds MODULE_PARM_DESC() for 'modinfo scsi_debug' online help Doug Gilbert > --- > drivers/scsi/scsi_debug.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c > index d323523f5f9d..8cf3f6c3f4f9 100644 > --- a/drivers/scsi/scsi_debug.c > +++ b/drivers/scsi/scsi_debug.c > @@ -665,6 +665,7 @@ static bool have_dif_prot; > static bool write_since_sync; > static bool sdebug_statistics = DEF_STATISTICS; > static bool sdebug_wp; > +static bool sdebug_host_tagset = false; > > static unsigned int sdebug_store_sectors; > static sector_t sdebug_capacity; /* in sectors */ > @@ -4468,6 +4469,7 @@ module_param_named(vpd_use_hostno, sdebug_vpd_use_hostno, int, > module_param_named(wp, sdebug_wp, bool, S_IRUGO | S_IWUSR); > module_param_named(write_same_length, sdebug_write_same_length, int, > S_IRUGO | S_IWUSR); > +module_param_named(host_tagset, sdebug_host_tagset, bool, S_IRUGO | S_IWUSR); > > MODULE_AUTHOR("Eric Youngdale + Douglas Gilbert"); > MODULE_DESCRIPTION("SCSI debug adapter driver"); > @@ -5779,6 +5781,7 @@ static int sdebug_driver_probe(struct device *dev) > sdbg_host = to_sdebug_host(dev); > > sdebug_driver_template.can_queue = sdebug_max_queue; > + sdebug_driver_template.host_tagset = sdebug_host_tagset; > if (!sdebug_clustering) > sdebug_driver_template.dma_boundary = PAGE_SIZE - 1; > > From bb14859f821ade9e3a0ee5f187e66a419d310ec0 Mon Sep 17 00:00:00 2001 From: Douglas Gilbert <dgilbert@interlog.com> Date: Sat, 1 Jun 2019 18:07:51 -0400 Subject: [PATCH 2/2] sg: convert to blk_mq hw queue; Ming Lei Signed-off-by: Douglas Gilbert <dgilbert@interlog.com> --- drivers/scsi/scsi_debug.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index e27f4df24021..a880ac4d13f8 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -669,6 +669,7 @@ static bool sdebug_clustering; static bool sdebug_host_lock = DEF_HOST_LOCK; static bool sdebug_strict = DEF_STRICT; static bool sdebug_any_injecting_opt; +static bool sdebug_host_tagset; static bool sdebug_verbose; static bool have_dif_prot; static bool write_since_sync; @@ -4515,6 +4516,7 @@ module_param_named(every_nth, sdebug_every_nth, int, S_IRUGO | S_IWUSR); module_param_named(fake_rw, sdebug_fake_rw, int, S_IRUGO | S_IWUSR); module_param_named(guard, sdebug_guard, uint, S_IRUGO); module_param_named(host_lock, sdebug_host_lock, bool, S_IRUGO | S_IWUSR); +module_param_named(host_tagset, sdebug_host_tagset, bool, 0644); module_param_string(inq_vendor, sdebug_inq_vendor_id, sizeof(sdebug_inq_vendor_id), S_IRUGO|S_IWUSR); module_param_string(inq_product, sdebug_inq_product_id, @@ -4575,6 +4577,7 @@ MODULE_PARM_DESC(every_nth, "timeout every nth command(def=0)"); MODULE_PARM_DESC(fake_rw, "fake reads/writes instead of copying (def=0)"); MODULE_PARM_DESC(guard, "protection checksum: 0=crc, 1=ip (def=0)"); MODULE_PARM_DESC(host_lock, "host_lock is ignored (def=0)"); +MODULE_PARM_DESC(host_tagset, "host_tagset for multiple hw queues (def=0)"); MODULE_PARM_DESC(inq_vendor, "SCSI INQUIRY vendor string (def=\"Linux\")"); MODULE_PARM_DESC(inq_product, "SCSI INQUIRY product string (def=\"scsi_debug\")"); MODULE_PARM_DESC(inq_rev, "SCSI INQUIRY revision string (def=\"" @@ -5866,6 +5869,7 @@ static int sdebug_driver_probe(struct device *dev) sdbg_host = to_sdebug_host(dev); sdebug_driver_template.can_queue = sdebug_max_queue; + sdebug_driver_template.host_tagset = sdebug_host_tagset; if (!sdebug_clustering) sdebug_driver_template.dma_boundary = PAGE_SIZE - 1;
diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index d323523f5f9d..8cf3f6c3f4f9 100644 --- a/drivers/scsi/scsi_debug.c +++ b/drivers/scsi/scsi_debug.c @@ -665,6 +665,7 @@ static bool have_dif_prot; static bool write_since_sync; static bool sdebug_statistics = DEF_STATISTICS; static bool sdebug_wp; +static bool sdebug_host_tagset = false; static unsigned int sdebug_store_sectors; static sector_t sdebug_capacity; /* in sectors */ @@ -4468,6 +4469,7 @@ module_param_named(vpd_use_hostno, sdebug_vpd_use_hostno, int, module_param_named(wp, sdebug_wp, bool, S_IRUGO | S_IWUSR); module_param_named(write_same_length, sdebug_write_same_length, int, S_IRUGO | S_IWUSR); +module_param_named(host_tagset, sdebug_host_tagset, bool, S_IRUGO | S_IWUSR); MODULE_AUTHOR("Eric Youngdale + Douglas Gilbert"); MODULE_DESCRIPTION("SCSI debug adapter driver"); @@ -5779,6 +5781,7 @@ static int sdebug_driver_probe(struct device *dev) sdbg_host = to_sdebug_host(dev); sdebug_driver_template.can_queue = sdebug_max_queue; + sdebug_driver_template.host_tagset = sdebug_host_tagset; if (!sdebug_clustering) sdebug_driver_template.dma_boundary = PAGE_SIZE - 1;
The 'host_tagset' can be set on scsi_debug device for testing shared hostwide tags on multiple blk-mq hw queue. Signed-off-by: Ming Lei <ming.lei@redhat.com> --- drivers/scsi/scsi_debug.c | 3 +++ 1 file changed, 3 insertions(+)