| Message ID | 20200128084434.128750-3-dwagner@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | nmve/018 fixes | expand |
> -----Original Message----- > From: linux-block-owner@vger.kernel.org <linux-block- > owner@vger.kernel.org> On Behalf Of Daniel Wagner > Sent: Tuesday, January 28, 2020 2:45 AM > Subject: [PATCH blktests v1 2/2] nmve/018: Reword misleading error message > > 'nvme read' is expected to fail, though the error message "ERROR: > Successfully..." is misleading. Reword the error text to clarify the > real indent of the test and what failed. intent > > Reported-by: Logan Gunthorpe <logang@deltatee.com> > Signed-off-by: Daniel Wagner <dwagner@suse.de> ... > - && echo "ERROR: Successfully read out of device lba range" > + && echo "ERROR: nvme read was successful for out of range lba" > To avoid being picked up by a grep for "success", you could use: ERROR: nvme read for out of range LBA was not rejected
diff --git a/tests/nvme/018 b/tests/nvme/018 index d0f15db23538..aa9681b312f7 100755 --- a/tests/nvme/018 +++ b/tests/nvme/018 @@ -44,7 +44,7 @@ test() { bs="$(blockdev --getbsz "/dev/${nvmedev}n1")" nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \ - && echo "ERROR: Successfully read out of device lba range" + && echo "ERROR: nvme read was successful for out of range lba" nvme disconnect -n "${subsys_name}"
'nvme read' is expected to fail, though the error message "ERROR: Successfully..." is misleading. Reword the error text to clarify the real indent of the test and what failed. Reported-by: Logan Gunthorpe <logang@deltatee.com> Signed-off-by: Daniel Wagner <dwagner@suse.de> --- tests/nvme/018 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)