diff mbox series

[blktests,v3,2/2] nvme/018: Reword misleading error message

Message ID 20200203164049.140280-3-dwagner@suse.de (mailing list archive)
State New, archived
Headers show
Series nmve/018 fixes | expand

Commit Message

Daniel Wagner Feb. 3, 2020, 4:40 p.m. UTC 
'nvme read' is expected to fail, though the error message "ERROR:
Successfully..." is misleading. Reword the error text to clarify the
real intent of the test and what failed.

Reported-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
---
 tests/nvme/018 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chaitanya Kulkarni Feb. 3, 2020, 9:08 p.m. UTC | #1 
On 02/03/2020 08:41 AM, Daniel Wagner wrote:
> 'nvme read' is expected to fail, though the error message "ERROR:
> Successfully..." is misleading. Reword the error text to clarify the
> real intent of the test and what failed.
>
> Reported-by: Logan Gunthorpe<logang@deltatee.com>
> Signed-off-by: Daniel Wagner<dwagner@suse.de>
> Reviewed-by: Logan Gunthorpe<logang@deltatee.com>
> Reviewed-by: Keith Busch<kbusch@kernel.org>
> ---
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
diff mbox series

Patch

diff --git a/tests/nvme/018 b/tests/nvme/018
index d0f15db23538..67d89a6f0b24 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -3,7 +3,7 @@ 
 # Copyright (C) 2018 Sagi Grimberg
 #
 # Test NVMe out of range access on a file backend. Regression test for commit
-# 9c891c139894 ("nvmet: check fileio lba range access boundaries").
+# 9c891c139894 ("nvmet: check fileio LBA range access boundaries").
 
 . tests/nvme/rc
 
@@ -44,7 +44,7 @@  test() {
 	bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
 
 	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
-		&& echo "ERROR: Successfully read out of device lba range"
+		&& echo "ERROR: nvme read for out of range LBA was not rejected"
 
 	nvme disconnect -n "${subsys_name}"