diff mbox series

[3/6] block: remove redundant setting of QUEUE_FLAG_DYING

Message ID 20200228150518.10496-4-guoqing.jiang@cloud.ionos.com (mailing list archive)
State New, archived
Headers show
Series Some cleanups for blk-core.c and blk-flush.c | expand

Commit Message

Guoqing Jiang Feb. 28, 2020, 3:05 p.m. UTC 
Previously, blk_cleanup_queue has called blk_set_queue_dying to set the
flag, no need to do it again.

Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
---
 block/blk-core.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Nikolay Borisov Feb. 28, 2020, 10:38 p.m. UTC | #1 
On 28.02.20 г. 17:05 ч., Guoqing Jiang wrote:
> Previously, blk_cleanup_queue has called blk_set_queue_dying to set the
> flag, no need to do it again.
> 
> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
> ---
>  block/blk-core.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/block/blk-core.c b/block/blk-core.c
> index 6d36c2ad40ba..883ffda216e4 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -346,7 +346,6 @@ void blk_cleanup_queue(struct request_queue *q)
>  
>  	blk_queue_flag_set(QUEUE_FLAG_NOMERGES, q);
>  	blk_queue_flag_set(QUEUE_FLAG_NOXMERGES, q);
> -	blk_queue_flag_set(QUEUE_FLAG_DYING, q);
>  
>  	/*
>  	 * Drain all requests queued before DYING marking. Set DEAD flag to
> 


Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Bart Van Assche Feb. 29, 2020, 2:27 a.m. UTC | #2 
On 2020-02-28 07:05, Guoqing Jiang wrote:
> Previously, blk_cleanup_queue has called blk_set_queue_dying to set the
> flag, no need to do it again.

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Chaitanya Kulkarni Feb. 29, 2020, 11:12 p.m. UTC | #3 
Looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

On 02/28/2020 07:06 AM, Guoqing Jiang wrote:
> Previously, blk_cleanup_queue has called blk_set_queue_dying to set the
> flag, no need to do it again.
>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
diff mbox series

Patch

diff --git a/block/blk-core.c b/block/blk-core.c
index 6d36c2ad40ba..883ffda216e4 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -346,7 +346,6 @@  void blk_cleanup_queue(struct request_queue *q)
 
 	blk_queue_flag_set(QUEUE_FLAG_NOMERGES, q);
 	blk_queue_flag_set(QUEUE_FLAG_NOXMERGES, q);
-	blk_queue_flag_set(QUEUE_FLAG_DYING, q);
 
 	/*
 	 * Drain all requests queued before DYING marking. Set DEAD flag to