| Message ID | 20200228150518.10496-6-guoqing.jiang@cloud.ionos.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Some cleanups for blk-core.c and blk-flush.c | expand |
On 28.02.20 г. 17:05 ч., Guoqing Jiang wrote: > Remove 'q' from arguments since it is not used anymore after > commit 7e992f847a08e ("block: remove non mq parts from the > flush code"). > > Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> Reviewed-by: Nikolay Borisov <nborisov@suse.com>
On 2020-02-28 07:05, Guoqing Jiang wrote: > Remove 'q' from arguments since it is not used anymore after > commit 7e992f847a08e ("block: remove non mq parts from the > flush code"). Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Looks good, except I did not count but please verify the patch subject length, otherwise looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> On 02/28/2020 07:07 AM, Guoqing Jiang wrote: > Remove 'q' from arguments since it is not used anymore after > commit 7e992f847a08e ("block: remove non mq parts from the > flush code"). > > Signed-off-by: Guoqing Jiang<guoqing.jiang@cloud.ionos.com>
On 3/1/20 12:19 AM, Chaitanya Kulkarni wrote: > Looks good, except I did not count but please verify the > patch subject length, otherwise looks good. > > Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> > Thanks for your review, I assume it is fine since checkpatch didn't complain. Thanks, Guoqing
diff --git a/block/blk-flush.c b/block/blk-flush.c index 3f977c517960..963ae56d5aae 100644 --- a/block/blk-flush.c +++ b/block/blk-flush.c @@ -485,8 +485,8 @@ int blkdev_issue_flush(struct block_device *bdev, gfp_t gfp_mask, } EXPORT_SYMBOL(blkdev_issue_flush); -struct blk_flush_queue *blk_alloc_flush_queue(struct request_queue *q, - int node, int cmd_size, gfp_t flags) +struct blk_flush_queue *blk_alloc_flush_queue(int node, int cmd_size, + gfp_t flags) { struct blk_flush_queue *fq; int rq_sz = sizeof(struct request); diff --git a/block/blk-mq.c b/block/blk-mq.c index a12b1763508d..9684ea9a9e1f 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -2405,8 +2405,7 @@ blk_mq_alloc_hctx(struct request_queue *q, struct blk_mq_tag_set *set, init_waitqueue_func_entry(&hctx->dispatch_wait, blk_mq_dispatch_wake); INIT_LIST_HEAD(&hctx->dispatch_wait.entry); - hctx->fq = blk_alloc_flush_queue(q, hctx->numa_node, set->cmd_size, - gfp); + hctx->fq = blk_alloc_flush_queue(hctx->numa_node, set->cmd_size, gfp); if (!hctx->fq) goto free_bitmap; diff --git a/block/blk.h b/block/blk.h index 0b8884353f6b..670337b7cfa0 100644 --- a/block/blk.h +++ b/block/blk.h @@ -55,8 +55,8 @@ is_flush_rq(struct request *req, struct blk_mq_hw_ctx *hctx) return hctx->fq->flush_rq == req; } -struct blk_flush_queue *blk_alloc_flush_queue(struct request_queue *q, - int node, int cmd_size, gfp_t flags); +struct blk_flush_queue *blk_alloc_flush_queue(int node, int cmd_size, + gfp_t flags); void blk_free_flush_queue(struct blk_flush_queue *q); void blk_freeze_queue(struct request_queue *q);
Remove 'q' from arguments since it is not used anymore after commit 7e992f847a08e ("block: remove non mq parts from the flush code"). Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com> --- block/blk-flush.c | 4 ++-- block/blk-mq.c | 3 +-- block/blk.h | 4 ++-- 3 files changed, 5 insertions(+), 6 deletions(-)