diff mbox series

[6/6] block: cleanup comment for blk_flush_complete_seq

Message ID 20200228150518.10496-7-guoqing.jiang@cloud.ionos.com (mailing list archive)
State New, archived
Headers show
Series Some cleanups for blk-core.c and blk-flush.c | expand

Commit Message

Guoqing Jiang Feb. 28, 2020, 3:05 p.m. UTC 
Remove the comment about return value, since it is not valid after
commit 404b8f5a03d84 ("block: cleanup kick/queued handling").

Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
---
 block/blk-flush.c | 3 ---
 1 file changed, 3 deletions(-)

Comments

Nikolay Borisov Feb. 28, 2020, 10:41 p.m. UTC | #1 
On 28.02.20 г. 17:05 ч., Guoqing Jiang wrote:
> Remove the comment about return value, since it is not valid after
> commit 404b8f5a03d84 ("block: cleanup kick/queued handling").
> 
> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>

Obviously correct, given the function is void.

Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Bart Van Assche Feb. 29, 2020, 2:36 a.m. UTC | #2 
On 2020-02-28 07:05, Guoqing Jiang wrote:
> Remove the comment about return value, since it is not valid after
> commit 404b8f5a03d84 ("block: cleanup kick/queued handling").

Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Chaitanya Kulkarni Feb. 29, 2020, 11:58 p.m. UTC | #3 
Looks good to me.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

On 02/28/2020 07:06 AM, Guoqing Jiang wrote:
> Remove the comment about return value, since it is not valid after
> commit 404b8f5a03d84 ("block: cleanup kick/queued handling").
>
> Signed-off-by: Guoqing Jiang<guoqing.jiang@cloud.ionos.com>
diff mbox series

Patch

diff --git a/block/blk-flush.c b/block/blk-flush.c
index 963ae56d5aae..46fd6e83dd79 100644
--- a/block/blk-flush.c
+++ b/block/blk-flush.c
@@ -160,9 +160,6 @@  static void blk_account_io_flush(struct request *rq)
  *
  * CONTEXT:
  * spin_lock_irq(fq->mq_flush_lock)
- *
- * RETURNS:
- * %true if requests were added to the dispatch queue, %false otherwise.
  */
 static void blk_flush_complete_seq(struct request *rq,
 				   struct blk_flush_queue *fq,