diff mbox series

blk-mq: make function '__blk_mq_sched_dispatch_requests' static

Message ID 20200429013632.38276-1-zhengbin13@huawei.com (mailing list archive)
State New, archived
Headers show
Series blk-mq: make function '__blk_mq_sched_dispatch_requests' static | expand

Commit Message

Zheng Bin April 29, 2020, 1:36 a.m. UTC
Fix sparse warnings:

block/blk-mq-sched.c:209:5: warning: symbol '__blk_mq_sched_dispatch_requests' was not declared. Should it be static?

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
 block/blk-mq-sched.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.26.0.106.g9fadedd

Comments

Christoph Hellwig April 29, 2020, 7:26 a.m. UTC | #1
On Wed, Apr 29, 2020 at 09:36:32AM +0800, Zheng Bin wrote:
> Fix sparse warnings:
> 
> block/blk-mq-sched.c:209:5: warning: symbol '__blk_mq_sched_dispatch_requests' was not declared. Should it be static?

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Jens Axboe April 29, 2020, 3:17 p.m. UTC | #2
On 4/28/20 7:36 PM, Zheng Bin wrote:
> Fix sparse warnings:
> 
> block/blk-mq-sched.c:209:5: warning: symbol '__blk_mq_sched_dispatch_requests' was not declared. Should it be static?

Applied, thanks.
diff mbox series

Patch

diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
index 702ce525933c..fdcc2c1dd178 100644
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -206,7 +206,7 @@  static int blk_mq_do_dispatch_ctx(struct blk_mq_hw_ctx *hctx)
 	return ret;
 }

-int __blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx)
+static int __blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx)
 {
 	struct request_queue *q = hctx->queue;
 	struct elevator_queue *e = q->elevator;