| Message ID | 20200501134416.72248-2-efremov@linux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | floppy: suppress UBSAN warning in setup_rw_floppy() | expand |
On Fri, May 01, 2020 at 04:44:13PM +0300, Denis Efremov wrote: > Remove pr_cont() and use print_hex_dump() in setup_DMA() to print the > contents of the cmd buffer. > > Suggested-by: Joe Perches <joe@perches.com> > Signed-off-by: Denis Efremov <efremov@linux.com> Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c index 2817170dd403..3ab6e804b5ec 100644 --- a/drivers/block/floppy.c +++ b/drivers/block/floppy.c @@ -1069,12 +1069,9 @@ static void setup_DMA(void) unsigned long f; if (raw_cmd->length == 0) { - int i; - - pr_info("zero dma transfer size:"); - for (i = 0; i < raw_cmd->cmd_count; i++) - pr_cont("%x,", raw_cmd->cmd[i]); - pr_cont("\n"); + print_hex_dump(KERN_INFO, "zero dma transfer size: ", + DUMP_PREFIX_NONE, 16, 1, + raw_cmd->cmd, raw_cmd->cmd_count, false); cont->done(0); fdc_state[current_fdc].reset = 1; return;
Remove pr_cont() and use print_hex_dump() in setup_DMA() to print the contents of the cmd buffer. Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Denis Efremov <efremov@linux.com> --- drivers/block/floppy.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)