| Message ID | 20200702053635.29386-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [-next,v2] block: remove unused but set variable 'hctx' | expand |
On 7/1/20 11:36 PM, Wei Yongjun wrote: > After commit 37f4a24c2469 ("blk-mq: centralise related handling > into blk_mq_get_driver_tag"), 'hctx' is never be used. Gcc report > build warning: > > block/blk-flush.c:222:24: warning: > variable hctx set but not used [-Wunused-but-set-variable] > 222 | struct blk_mq_hw_ctx *hctx; > | ^~~~ > > Just removing it to avoid build warning. I reverted that patch that introduced this issue, so I'm expecting this one to just be folded in with a resubmission.
diff --git a/block/blk-flush.c b/block/blk-flush.c index e756db088d84..a20fe125e9fa 100644 --- a/block/blk-flush.c +++ b/block/blk-flush.c @@ -219,7 +219,6 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error) struct request *rq, *n; unsigned long flags = 0; struct blk_flush_queue *fq = blk_get_flush_queue(q, flush_rq->mq_ctx); - struct blk_mq_hw_ctx *hctx; blk_account_io_flush(flush_rq); @@ -235,7 +234,6 @@ static void flush_end_io(struct request *flush_rq, blk_status_t error) if (fq->rq_status != BLK_STS_OK) error = fq->rq_status; - hctx = flush_rq->mq_hctx; if (!q->elevator) flush_rq->tag = BLK_MQ_NO_TAG; else
After commit 37f4a24c2469 ("blk-mq: centralise related handling into blk_mq_get_driver_tag"), 'hctx' is never be used. Gcc report build warning: block/blk-flush.c:222:24: warning: variable hctx set but not used [-Wunused-but-set-variable] 222 | struct blk_mq_hw_ctx *hctx; | ^~~~ Just removing it to avoid build warning. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Reviewed-by: Ming Lei <ming.lei@redhat.com> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> --- v1 -> v2: fix signed-off-by --- block/blk-flush.c | 2 -- 1 file changed, 2 deletions(-)