diff mbox series

blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats

Message ID 20201114181246.107007-1-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series blk-cgroup: fix a hd_struct leak in blkcg_fill_root_iostats | expand

Commit Message

Christoph Hellwig Nov. 14, 2020, 6:12 p.m. UTC 
disk_get_part needs to be paired with a disk_put_part.

Fixes: ef45fe470e1 ("blk-cgroup: show global disk stats in root cgroup io.stat")
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/blk-cgroup.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jens Axboe Nov. 14, 2020, 6:17 p.m. UTC | #1 
On 11/14/20 11:12 AM, Christoph Hellwig wrote:
> disk_get_part needs to be paired with a disk_put_part.

Applied, thanks.
diff mbox series

Patch

diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c
index c68bdf58c9a6e1..54fbe1e80cc41a 100644
--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -849,6 +849,7 @@  static void blkcg_fill_root_iostats(void)
 			blkg_iostat_set(&blkg->iostat.cur, &tmp);
 			u64_stats_update_end(&blkg->iostat.sync);
 		}
+		disk_put_part(part);
 	}
 }