From patchwork Mon Nov 16 21:20:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 11910893 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC43BC63777 for ; Mon, 16 Nov 2020 21:20:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F28B2224F for ; Mon, 16 Nov 2020 21:20:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="s8gIYR5d" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727069AbgKPVUb (ORCPT ); Mon, 16 Nov 2020 16:20:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52598 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726852AbgKPVUb (ORCPT ); Mon, 16 Nov 2020 16:20:31 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 621BBC0613CF for ; Mon, 16 Nov 2020 13:20:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=2AKcef4DY6iJcprvQynjGgbCIgh8d3+qztu8J6nwbBU=; b=s8gIYR5dNXyULF41wkVeN9JoYs w1qbUbw8DZVaWh/Nx1VikpTJFzOog/0qnzGumVS+mBj0xa/7GlsuCv8VMD+VnCTOgldvdAisRSakg oWgc+vEBU+bI03fNtBZ2pvppNZ6aGt/flOwNSpEzhPxwNFO13sYIkOGdbUQGpThYi9Hz2fQkIMwNH oqJNUNvvVy3qA8i8KTdKjrCbGG/wZPGxPHNy1jUBbZB7B98ENnfuyTA0sE1MKSgbpA8gMvFpEqXSS 87eAI7GfavnIPUj/7H1RxKgeheWzY8myvGYfSPRrt12MmIufmPlp69HcxoZK//ngXTYbR5sfewQcF F6Xx3tJA==; Received: from [2001:4bb8:180:6600:255b:7def:a93:4a09] (helo=localhost) by casper.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kelvG-0007P0-K7; Mon, 16 Nov 2020 21:20:26 +0000 From: Christoph Hellwig To: Jens Axboe , Minchan Kim , Mike Snitzer Cc: dm-devel@redhat.com, linux-block@vger.kernel.org Subject: [PATCH 4/6] loop: do not call set_blocksize Date: Mon, 16 Nov 2020 22:20:18 +0100 Message-Id: <20201116212020.1099154-5-hch@lst.de> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201116212020.1099154-1-hch@lst.de> References: <20201116212020.1099154-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org set_blocksize is used by file systems to use their preferred buffer cache block size. Block drivers should not set it. Signed-off-by: Christoph Hellwig --- drivers/block/loop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 9a27d4f1c08aac..b42c728620c9e4 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1164,9 +1164,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode, size = get_loop_size(lo, file); loop_set_size(lo, size); - set_blocksize(bdev, S_ISBLK(inode->i_mode) ? - block_size(inode->i_bdev) : PAGE_SIZE); - lo->lo_state = Lo_bound; if (part_shift) lo->lo_flags |= LO_FLAGS_PARTSCAN;