| Message ID | 20201201165424.2030647-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/9] brd: remove the end of device check in brd_do_bvec | expand |
On Tue, Dec 01, 2020 at 05:54:16PM +0100, Christoph Hellwig wrote: > The block layer already checks for this conditions in bio_check_eod > before calling the driver. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Acked-by: Tejun Heo <tj@kernel.org> Thanks.
diff --git a/drivers/block/brd.c b/drivers/block/brd.c index c43a6ab4b1f39f..c7c8214190795c 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -285,14 +285,10 @@ static int brd_do_bvec(struct brd_device *brd, struct page *page, static blk_qc_t brd_submit_bio(struct bio *bio) { struct brd_device *brd = bio->bi_disk->private_data; + sector_t sector = bio->bi_iter.bi_sector; struct bio_vec bvec; - sector_t sector; struct bvec_iter iter; - sector = bio->bi_iter.bi_sector; - if (bio_end_sector(bio) > get_capacity(bio->bi_disk)) - goto io_error; - bio_for_each_segment(bvec, bio, iter) { unsigned int len = bvec.bv_len; int err;
The block layer already checks for this conditions in bio_check_eod before calling the driver. Signed-off-by: Christoph Hellwig <hch@lst.de> --- drivers/block/brd.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)