| Message ID | 20201222031154.62150-1-jefflexu@linux.alibaba.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: move definition of blk_qc_t to types.h | expand |
> -typedef unsigned int blk_qc_t; > #define BLK_QC_T_NONE -1U > #define BLK_QC_T_SHIFT 16 > #define BLK_QC_T_INTERNAL (1U << 31) I think we need a comment here explaining these are the values for blk_qc_t at least.
On 12/22/20 9:30 PM, Christoph Hellwig wrote: >> -typedef unsigned int blk_qc_t; >> #define BLK_QC_T_NONE -1U >> #define BLK_QC_T_SHIFT 16 >> #define BLK_QC_T_INTERNAL (1U << 31) > > I think we need a comment here explaining these are the values for > blk_qc_t at least. > Regards. Thanks.
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h index 866f74261b3b..437e1f74edf8 100644 --- a/include/linux/blk_types.h +++ b/include/linux/blk_types.h @@ -532,7 +532,6 @@ static inline int op_stat_group(unsigned int op) return op_is_write(op); } -typedef unsigned int blk_qc_t; #define BLK_QC_T_NONE -1U #define BLK_QC_T_SHIFT 16 #define BLK_QC_T_INTERNAL (1U << 31) diff --git a/include/linux/fs.h b/include/linux/fs.h index b0b358309657..88ec2c9ed497 100644 --- a/include/linux/fs.h +++ b/include/linux/fs.h @@ -330,7 +330,7 @@ struct kiocb { u16 ki_hint; u16 ki_ioprio; /* See linux/ioprio.h */ union { - unsigned int ki_cookie; /* for ->iopoll */ + blk_qc_t ki_cookie; /* for ->iopoll */ struct wait_page_queue *ki_waitq; /* for async buffered IO */ }; diff --git a/include/linux/types.h b/include/linux/types.h index a147977602b5..bf4a64b6f13e 100644 --- a/include/linux/types.h +++ b/include/linux/types.h @@ -125,6 +125,8 @@ typedef s64 int64_t; typedef u64 sector_t; typedef u64 blkcnt_t; +typedef unsigned int blk_qc_t; + /* * The type of an index into the pagecache. */
So that kiocb.ki_cookie can be defined as blk_qc_t, which will enforce the encapsulation. Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> --- include/linux/blk_types.h | 1 - include/linux/fs.h | 2 +- include/linux/types.h | 2 ++ 3 files changed, 3 insertions(+), 2 deletions(-)