Message ID | 20210111030557.4154161-7-ming.lei@redhat.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | block: improvement on bioset & bvec allocation | expand |
On 1/11/21 11:05 AM, Ming Lei wrote: > This bioset is just for allocating bio only from bio_next_split, and it > needn't bvecs, so remove the flag. > > Cc: linux-bcache@vger.kernel.org > Cc: Coly Li <colyli@suse.de> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Ming Lei <ming.lei@redhat.com> Acked-by: Coly Li <colyli@suse.de> Thanks. Coly Li > --- > drivers/md/bcache/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index a4752ac410dc..4102e47f43e1 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -1897,7 +1897,7 @@ struct cache_set *bch_cache_set_alloc(struct cache_sb *sb) > goto err; > > if (bioset_init(&c->bio_split, 4, offsetof(struct bbio, bio), > - BIOSET_NEED_BVECS|BIOSET_NEED_RESCUER)) > + BIOSET_NEED_RESCUER)) > goto err; > > c->uuids = alloc_meta_bucket_pages(GFP_KERNEL, sb); >
On 1/11/21 4:05 AM, Ming Lei wrote: > This bioset is just for allocating bio only from bio_next_split, and it > needn't bvecs, so remove the flag. > > Cc: linux-bcache@vger.kernel.org > Cc: Coly Li <colyli@suse.de> > Reviewed-by: Christoph Hellwig <hch@lst.de> > Signed-off-by: Ming Lei <ming.lei@redhat.com> > --- > drivers/md/bcache/super.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index a4752ac410dc..4102e47f43e1 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -1897,7 +1897,7 @@ struct cache_set *bch_cache_set_alloc(struct cache_sb *sb) > goto err; > > if (bioset_init(&c->bio_split, 4, offsetof(struct bbio, bio), > - BIOSET_NEED_BVECS|BIOSET_NEED_RESCUER)) > + BIOSET_NEED_RESCUER)) > goto err; > > c->uuids = alloc_meta_bucket_pages(GFP_KERNEL, sb); > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index a4752ac410dc..4102e47f43e1 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -1897,7 +1897,7 @@ struct cache_set *bch_cache_set_alloc(struct cache_sb *sb) goto err; if (bioset_init(&c->bio_split, 4, offsetof(struct bbio, bio), - BIOSET_NEED_BVECS|BIOSET_NEED_RESCUER)) + BIOSET_NEED_RESCUER)) goto err; c->uuids = alloc_meta_bucket_pages(GFP_KERNEL, sb);