diff mbox series

block: remove RQF_ALLOCED

Message ID 20210317072122.155380-1-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series block: remove RQF_ALLOCED | expand

Commit Message

Christoph Hellwig March 17, 2021, 7:21 a.m. UTC 
This flag is not used anywhere.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 include/linux/blkdev.h | 2 --
 1 file changed, 2 deletions(-)

Comments

Christoph Hellwig March 17, 2021, 1:42 p.m. UTC | #1 
On Wed, Mar 17, 2021 at 08:21:22AM +0100, Christoph Hellwig wrote:
> This flag is not used anywhere.

Except that blk-mq-debugfs prints it in a completely obsfucated way.
Sight, I'll need to fix that mess while I'm at it.
Chaitanya Kulkarni March 18, 2021, 1:18 a.m. UTC | #2 
On 3/17/21 06:43, Christoph Hellwig wrote:
> On Wed, Mar 17, 2021 at 08:21:22AM +0100, Christoph Hellwig wrote:
>> This flag is not used anywhere.
> Except that blk-mq-debugfs prints it in a completely obsfucated way.
> Sight, I'll need to fix that mess while I'm at it.
>

If you are going to fix this, does it makes sense to fix the rest of
the obfuscation ? such as QUEUE_FLAGE_NAME/HCTX_FLAG_NAME/CMD_FLAG_NAME ?
Chaitanya Kulkarni March 18, 2021, 1:49 a.m. UTC | #3 
On 3/17/21 18:18, Chaitanya Kulkarni wrote:
> On 3/17/21 06:43, Christoph Hellwig wrote:
>> On Wed, Mar 17, 2021 at 08:21:22AM +0100, Christoph Hellwig wrote:
>>> This flag is not used anywhere.
>> Except that blk-mq-debugfs prints it in a completely obsfucated way.
>> Sight, I'll need to fix that mess while I'm at it.
>>
> If you are going to fix this, does it makes sense to fix the rest of
> the obfuscation ? such as QUEUE_FLAGE_NAME/HCTX_FLAG_NAME/CMD_FLAG_NAME ?
>
>
>

If so, I'd like to send a patch to remove obfuscation for blk_op_name[].

Please let me know.
diff mbox series

Patch

diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index bc6bc8383b434e..158aefae1030db 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -85,8 +85,6 @@  typedef __u32 __bitwise req_flags_t;
 #define RQF_ELVPRIV		((__force req_flags_t)(1 << 12))
 /* account into disk and partition IO statistics */
 #define RQF_IO_STAT		((__force req_flags_t)(1 << 13))
-/* request came from our alloc pool */
-#define RQF_ALLOCED		((__force req_flags_t)(1 << 14))
 /* runtime pm request */
 #define RQF_PM			((__force req_flags_t)(1 << 15))
 /* on IO scheduler merge hash */