diff mbox series

block: export disk_part_iter_* helpers

Message ID 20210326121059.597172-1-yanfei.xu@windriver.com (mailing list archive)
State New, archived
Headers show
Series block: export disk_part_iter_* helpers | expand

Commit Message

Xu, Yanfei March 26, 2021, 12:10 p.m. UTC
From: Yanfei Xu <yanfei.xu@windriver.com>

disk_part_iter_* helpers might be used by other external modules, like
lttng-modules. But it was unexport in 'commit bc359d03c7ec ("block: add
a disk_uevent helper")'. Here export them again.

Signed-off-by: Yanfei Xu <yanfei.xu@windriver.com>
---
 block/genhd.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Christoph Hellwig March 26, 2021, 12:13 p.m. UTC | #1
On Fri, Mar 26, 2021 at 08:10:59PM +0800, yanfei.xu@windriver.com wrote:
> From: Yanfei Xu <yanfei.xu@windriver.com>
> 
> disk_part_iter_* helpers might be used by other external modules, like
> lttng-modules. But it was unexport in 'commit bc359d03c7ec ("block: add
> a disk_uevent helper")'. Here export them again.

Err, no.  We never export things for out of tree modules.  And any kind
of driver code has absolutely no business looking at the partition tables
to start with, modular or not.
Xu, Yanfei March 26, 2021, 1:01 p.m. UTC | #2
On 3/26/21 8:13 PM, Christoph Hellwig wrote:
> [Please note: This e-mail is from an EXTERNAL e-mail address]
> 
> On Fri, Mar 26, 2021 at 08:10:59PM +0800, yanfei.xu@windriver.com wrote:
>> From: Yanfei Xu <yanfei.xu@windriver.com>
>>
>> disk_part_iter_* helpers might be used by other external modules, like
>> lttng-modules. But it was unexport in 'commit bc359d03c7ec ("block: add
>> a disk_uevent helper")'. Here export them again.
> 
> Err, no.  We never export things for out of tree modules.  And any kind
> of driver code has absolutely no business looking at the partition tables
> to start with, modular or not.
> I see. Thanks.

//Yanfei
diff mbox series

Patch

diff --git a/block/genhd.c b/block/genhd.c
index 8c8f543572e6..4eac897baffe 100644
--- a/block/genhd.c
+++ b/block/genhd.c
@@ -183,6 +183,7 @@  void disk_part_iter_init(struct disk_part_iter *piter, struct gendisk *disk,
 		piter->idx = 1;
 	piter->flags = flags;
 }
+EXPORT_SYMBOL_GPL(disk_part_iter_init);
 
 /**
  * disk_part_iter_next - proceed iterator to the next partition and return it
@@ -219,6 +220,7 @@  struct block_device *disk_part_iter_next(struct disk_part_iter *piter)
 
 	return piter->part;
 }
+EXPORT_SYMBOL_GPL(disk_part_iter_next);
 
 /**
  * disk_part_iter_exit - finish up partition iteration
@@ -235,6 +237,7 @@  void disk_part_iter_exit(struct disk_part_iter *piter)
 		bdput(piter->part);
 	piter->part = NULL;
 }
+EXPORT_SYMBOL_GPL(disk_part_iter_exit);
 
 /*
  * Can be deleted altogether. Later.