diff mbox series

[-next,1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock

Message ID 20210329095349.4170870-1-liushixin2@huawei.com (mailing list archive)
State New, archived
Headers show
Series [-next,1/2] mtip32xx: use DEFINE_SPINLOCK() for spinlock | expand

Commit Message

Liu Shixin March 29, 2021, 9:53 a.m. UTC 
spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
---
 drivers/block/mtip32xx/mtip32xx.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Jens Axboe March 29, 2021, 1:39 p.m. UTC | #1 
On 3/29/21 3:53 AM, Shixin Liu wrote:
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().

Applied both, thanks.
diff mbox series

Patch

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 3be0dbc674bd..39e3280030d6 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -97,7 +97,7 @@  static int instance;
 
 static struct list_head online_list;
 static struct list_head removing_list;
-static spinlock_t dev_lock;
+static DEFINE_SPINLOCK(dev_lock);
 
 /*
  * Global variable used to hold the major block device number
@@ -4363,8 +4363,6 @@  static int __init mtip_init(void)
 
 	pr_info(MTIP_DRV_NAME " Version " MTIP_DRV_VERSION "\n");
 
-	spin_lock_init(&dev_lock);
-
 	INIT_LIST_HEAD(&online_list);
 	INIT_LIST_HEAD(&removing_list);