| Message ID | 20210413034142.23460-1-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: Remove an obsolete comment from sg_io() | expand |
On 4/12/21 20:44, Bart Van Assche wrote: > Commit b7819b925918 ("block: remove the blk_execute_rq return value") > changed the return type of blk_execute_rq() from int into void. That > change made a comment in sg_io() obsolete. Hence remove that comment. > > Cc: Christoph Hellwig <hch@lst.de> > Cc: Johannes Thumshirn <jthumshirn@suse.de> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> On Apr 12, 2021, at 10:41 PM, Bart Van Assche <bvanassche@acm.org> wrote: > > Commit b7819b925918 ("block: remove the blk_execute_rq return value") > changed the return type of blk_execute_rq() from int into void. That > change made a comment in sg_io() obsolete. Hence remove that comment. > > Cc: Christoph Hellwig <hch@lst.de> > Cc: Johannes Thumshirn <jthumshirn@suse.de> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > block/scsi_ioctl.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c > index 1048b0925567..1b3fe99b83a6 100644 > --- a/block/scsi_ioctl.c > +++ b/block/scsi_ioctl.c > @@ -353,10 +353,6 @@ static int sg_io(struct request_queue *q, struct gendisk *bd_disk, > > start_time = jiffies; > > - /* ignore return value. All information is passed back to caller > - * (if he doesn't check that is his problem). > - * N.B. a non-zero SCSI status is _not_ necessarily an error. > - */ > blk_execute_rq(bd_disk, rq, at_head); > > hdr->duration = jiffies_to_msecs(jiffies - start_time); Looks Good. Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com> -- Himanshu Madhani Oracle Linux Engineering
On 4/12/21 9:41 PM, Bart Van Assche wrote: > Commit b7819b925918 ("block: remove the blk_execute_rq return value") > changed the return type of blk_execute_rq() from int into void. That > change made a comment in sg_io() obsolete. Hence remove that comment. Thanks, applied.
diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c index 1048b0925567..1b3fe99b83a6 100644 --- a/block/scsi_ioctl.c +++ b/block/scsi_ioctl.c @@ -353,10 +353,6 @@ static int sg_io(struct request_queue *q, struct gendisk *bd_disk, start_time = jiffies; - /* ignore return value. All information is passed back to caller - * (if he doesn't check that is his problem). - * N.B. a non-zero SCSI status is _not_ necessarily an error. - */ blk_execute_rq(bd_disk, rq, at_head); hdr->duration = jiffies_to_msecs(jiffies - start_time);
Commit b7819b925918 ("block: remove the blk_execute_rq return value") changed the return type of blk_execute_rq() from int into void. That change made a comment in sg_io() obsolete. Hence remove that comment. Cc: Christoph Hellwig <hch@lst.de> Cc: Johannes Thumshirn <jthumshirn@suse.de> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- block/scsi_ioctl.c | 4 ---- 1 file changed, 4 deletions(-)