diff mbox series

block: return -EBUSY when there are open partitions in blkdev_reread_part

Message ID 20210421160502.447418-1-hch@lst.de (mailing list archive)
State New
Headers show
Series block: return -EBUSY when there are open partitions in blkdev_reread_part | expand

Commit Message

Christoph Hellwig April 21, 2021, 4:05 p.m. UTC
The switch to go through blkdev_get_by_dev means we now ignore the
return value from bdev_disk_changed in __blkdev_get.  Add a manual
check to restore the old semantics.

Fixes: 4601b4b130de ("block: reopen the device in blkdev_reread_part")
Reported-by: Karel Zak <kzak@redhat.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 block/ioctl.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Jens Axboe April 21, 2021, 4:50 p.m. UTC | #1
On 4/21/21 10:05 AM, Christoph Hellwig wrote:
> The switch to go through blkdev_get_by_dev means we now ignore the
> return value from bdev_disk_changed in __blkdev_get.  Add a manual
> check to restore the old semantics.

Applied, thanks.
diff mbox series

Patch

diff --git a/block/ioctl.c b/block/ioctl.c
index ff241e663c018f..8ba1ed8defd0bb 100644
--- a/block/ioctl.c
+++ b/block/ioctl.c
@@ -89,6 +89,8 @@  static int blkdev_reread_part(struct block_device *bdev, fmode_t mode)
 		return -EINVAL;
 	if (!capable(CAP_SYS_ADMIN))
 		return -EACCES;
+	if (bdev->bd_part_count)
+		return -EBUSY;
 
 	/*
 	 * Reopen the device to revalidate the driver state and force a