diff mbox series

[for-next,1/4] block/rnbd-clt: Change queue_depth type in rnbd_clt_session to size_t

Message ID 20210428061359.206794-2-gi-oh.kim@ionos.com (mailing list archive)
State New, archived
Headers show
Series Misc update for RNBD | expand

Commit Message

Gioh Kim April 28, 2021, 6:13 a.m. UTC 
From: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>

The member queue_depth in the structure rnbd_clt_session is read from the
rtrs client side using the function rtrs_clt_query, which in turn is read
from the rtrs_clt structure. It should really be of type size_t.

Fixes: 90426e89f54db ("block/rnbd: client: private header with client structs and functions")
Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
Reviewed-by: Guoqing Jiang <guoqing.jiang@ionos.com>
Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
---
 drivers/block/rnbd/rnbd-clt.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chaitanya Kulkarni April 28, 2021, 6:27 p.m. UTC | #1 
On 4/27/21 23:14, Gioh Kim wrote:
> From: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
>
> The member queue_depth in the structure rnbd_clt_session is read from the
> rtrs client side using the function rtrs_clt_query, which in turn is read
> from the rtrs_clt structure. It should really be of type size_t.
>
> Fixes: 90426e89f54db ("block/rnbd: client: private header with client structs and functions")
> Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com>
> Reviewed-by: Guoqing Jiang <guoqing.jiang@ionos.com>
> Signed-off-by: Gioh Kim <gi-oh.kim@ionos.com>
> ---


Looks good.

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
diff mbox series

Patch

diff --git a/drivers/block/rnbd/rnbd-clt.h b/drivers/block/rnbd/rnbd-clt.h
index 451e7383738f..b5322c5aaac0 100644
--- a/drivers/block/rnbd/rnbd-clt.h
+++ b/drivers/block/rnbd/rnbd-clt.h
@@ -87,7 +87,7 @@  struct rnbd_clt_session {
 	DECLARE_BITMAP(cpu_queues_bm, NR_CPUS);
 	int	__percpu	*cpu_rr; /* per-cpu var for CPU round-robin */
 	atomic_t		busy;
-	int			queue_depth;
+	size_t			queue_depth;
 	u32			max_io_size;
 	struct blk_mq_tag_set	tag_set;
 	u32			nr_poll_queues;