| Message ID | 20210527010134.32448-5-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Improve I/O priority support | expand |
On 5/26/21 18:02, Bart Van Assche wrote: > Change "queue" into "sched" to make the function names reflect better the > purpose of these functions. > > Cc: Damien Le Moal <damien.lemoal@wdc.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Ming Lei <ming.lei@redhat.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Looks good. Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
On 2021/05/27 10:01, Bart Van Assche wrote: > Change "queue" into "sched" to make the function names reflect better the > purpose of these functions. Nit: may be change this to: Change "queue" into "sched" to make the function names match the elevator type operation names. > > Cc: Damien Le Moal <damien.lemoal@wdc.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Ming Lei <ming.lei@redhat.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > block/mq-deadline.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/block/mq-deadline.c b/block/mq-deadline.c > index cc9d0fc72db2..c4f51e7884fb 100644 > --- a/block/mq-deadline.c > +++ b/block/mq-deadline.c > @@ -395,7 +395,7 @@ static struct request *dd_dispatch_request(struct blk_mq_hw_ctx *hctx) > return rq; > } > > -static void dd_exit_queue(struct elevator_queue *e) > +static void dd_exit_sched(struct elevator_queue *e) > { > struct deadline_data *dd = e->elevator_data; > > @@ -408,7 +408,7 @@ static void dd_exit_queue(struct elevator_queue *e) > /* > * initialize elevator private data (deadline_data). > */ > -static int dd_init_queue(struct request_queue *q, struct elevator_type *e) > +static int dd_init_sched(struct request_queue *q, struct elevator_type *e) > { > struct deadline_data *dd; > struct elevator_queue *eq; > @@ -800,8 +800,8 @@ static struct elevator_type mq_deadline = { > .requests_merged = dd_merged_requests, > .request_merged = dd_request_merged, > .has_work = dd_has_work, > - .init_sched = dd_init_queue, > - .exit_sched = dd_exit_queue, > + .init_sched = dd_init_sched, > + .exit_sched = dd_exit_sched, > }, > > #ifdef CONFIG_BLK_DEBUG_FS > Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
On 5/27/21 3:01 AM, Bart Van Assche wrote: > Change "queue" into "sched" to make the function names reflect better the > purpose of these functions. > > Cc: Damien Le Moal <damien.lemoal@wdc.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Ming Lei <ming.lei@redhat.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > block/mq-deadline.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
On 5/26/21 8:01 PM, Bart Van Assche wrote: > Change "queue" into "sched" to make the function names reflect better the > purpose of these functions. > > Cc: Damien Le Moal <damien.lemoal@wdc.com> > Cc: Christoph Hellwig <hch@lst.de> > Cc: Ming Lei <ming.lei@redhat.com> > Signed-off-by: Bart Van Assche <bvanassche@acm.org> > --- > block/mq-deadline.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/block/mq-deadline.c b/block/mq-deadline.c > index cc9d0fc72db2..c4f51e7884fb 100644 > --- a/block/mq-deadline.c > +++ b/block/mq-deadline.c > @@ -395,7 +395,7 @@ static struct request *dd_dispatch_request(struct blk_mq_hw_ctx *hctx) > return rq; > } > > -static void dd_exit_queue(struct elevator_queue *e) > +static void dd_exit_sched(struct elevator_queue *e) > { > struct deadline_data *dd = e->elevator_data; > > @@ -408,7 +408,7 @@ static void dd_exit_queue(struct elevator_queue *e) > /* > * initialize elevator private data (deadline_data). > */ > -static int dd_init_queue(struct request_queue *q, struct elevator_type *e) > +static int dd_init_sched(struct request_queue *q, struct elevator_type *e) > { > struct deadline_data *dd; > struct elevator_queue *eq; > @@ -800,8 +800,8 @@ static struct elevator_type mq_deadline = { > .requests_merged = dd_merged_requests, > .request_merged = dd_request_merged, > .has_work = dd_has_work, > - .init_sched = dd_init_queue, > - .exit_sched = dd_exit_queue, > + .init_sched = dd_init_sched, > + .exit_sched = dd_exit_sched, > }, > > #ifdef CONFIG_BLK_DEBUG_FS > Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
On 5/26/21 8:13 PM, Damien Le Moal wrote: > On 2021/05/27 10:01, Bart Van Assche wrote: >> Change "queue" into "sched" to make the function names reflect better the >> purpose of these functions. > > Nit: may be change this to: > > Change "queue" into "sched" to make the function names match the elevator type > operation names. Hi Damien, The functions dd_init_sched() and dd_exit_sched() initialize a scheduler data structure. To me the names dd_init_queue() / dd_exit_queue() suggest that something in the request queue is initialized which is not the case. Is sufficient as clarification or do you still want me to change the patch description? Thanks, Bart.
diff --git a/block/mq-deadline.c b/block/mq-deadline.c index cc9d0fc72db2..c4f51e7884fb 100644 --- a/block/mq-deadline.c +++ b/block/mq-deadline.c @@ -395,7 +395,7 @@ static struct request *dd_dispatch_request(struct blk_mq_hw_ctx *hctx) return rq; } -static void dd_exit_queue(struct elevator_queue *e) +static void dd_exit_sched(struct elevator_queue *e) { struct deadline_data *dd = e->elevator_data; @@ -408,7 +408,7 @@ static void dd_exit_queue(struct elevator_queue *e) /* * initialize elevator private data (deadline_data). */ -static int dd_init_queue(struct request_queue *q, struct elevator_type *e) +static int dd_init_sched(struct request_queue *q, struct elevator_type *e) { struct deadline_data *dd; struct elevator_queue *eq; @@ -800,8 +800,8 @@ static struct elevator_type mq_deadline = { .requests_merged = dd_merged_requests, .request_merged = dd_request_merged, .has_work = dd_has_work, - .init_sched = dd_init_queue, - .exit_sched = dd_exit_queue, + .init_sched = dd_init_sched, + .exit_sched = dd_exit_sched, }, #ifdef CONFIG_BLK_DEBUG_FS
Change "queue" into "sched" to make the function names reflect better the purpose of these functions. Cc: Damien Le Moal <damien.lemoal@wdc.com> Cc: Christoph Hellwig <hch@lst.de> Cc: Ming Lei <ming.lei@redhat.com> Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- block/mq-deadline.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)