diff mbox series

pd: fix order of cleaning up the queue and freeing the tagset

Message ID 20210706010734.1356066-1-guoqing.jiang@linux.dev (mailing list archive)
State New, archived
Headers show
Series pd: fix order of cleaning up the queue and freeing the tagset | expand

Commit Message

Guoqing Jiang July 6, 2021, 1:07 a.m. UTC 
From: Guoqing Jiang <jiangguoqing@kylinos.cn>

We must release the queue before freeing the tagset.

Fixes: 262d431f9000 ("pd: use blk_mq_alloc_disk and blk_cleanup_disk")
Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
---
 drivers/block/paride/pd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig July 6, 2021, 4:17 a.m. UTC | #1 
On Tue, Jul 06, 2021 at 09:07:34AM +0800, Guoqing Jiang wrote:
> From: Guoqing Jiang <jiangguoqing@kylinos.cn>
> 
> We must release the queue before freeing the tagset.
> 
> Fixes: 262d431f9000 ("pd: use blk_mq_alloc_disk and blk_cleanup_disk")
> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
Christoph Hellwig July 15, 2021, 6:58 a.m. UTC | #2 
Jens, can you pick this one up?

On Tue, Jul 06, 2021 at 09:07:34AM +0800, Guoqing Jiang wrote:
> From: Guoqing Jiang <jiangguoqing@kylinos.cn>
> 
> We must release the queue before freeing the tagset.
> 
> Fixes: 262d431f9000 ("pd: use blk_mq_alloc_disk and blk_cleanup_disk")
> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
> ---
>  drivers/block/paride/pd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
> index 3b2b8e872beb..9b3298926356 100644
> --- a/drivers/block/paride/pd.c
> +++ b/drivers/block/paride/pd.c
> @@ -1014,8 +1014,8 @@ static void __exit pd_exit(void)
>  		if (p) {
>  			disk->gd = NULL;
>  			del_gendisk(p);
> -			blk_mq_free_tag_set(&disk->tag_set);
>  			blk_cleanup_disk(p);
> +			blk_mq_free_tag_set(&disk->tag_set);
>  			pi_release(disk->pi);
>  		}
>  	}
> -- 
> 2.25.1
> 
---end quoted text---
Jens Axboe July 15, 2021, 3:29 p.m. UTC | #3 
On 7/5/21 7:07 PM, Guoqing Jiang wrote:
> From: Guoqing Jiang <jiangguoqing@kylinos.cn>
> 
> We must release the queue before freeing the tagset.

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/block/paride/pd.c b/drivers/block/paride/pd.c
index 3b2b8e872beb..9b3298926356 100644
--- a/drivers/block/paride/pd.c
+++ b/drivers/block/paride/pd.c
@@ -1014,8 +1014,8 @@  static void __exit pd_exit(void)
 		if (p) {
 			disk->gd = NULL;
 			del_gendisk(p);
-			blk_mq_free_tag_set(&disk->tag_set);
 			blk_cleanup_disk(p);
+			blk_mq_free_tag_set(&disk->tag_set);
 			pi_release(disk->pi);
 		}
 	}