| Message ID | 20211112093728.3237-1-lukas.bulwahn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN | expand |
On Fri, Nov 12, 2021 at 10:37:28AM +0100, Lukas Bulwahn wrote: > Commit cd006509b0a9 ("blk-iocost: account for IO size when testing > latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in > config BLK_CGROUP_IOCOST. > > Hence, ./scripts/checkkconfigsymbols.py warns: > > BLK_RQ_IO_DATA_LEN > Referencing files: block/Kconfig > > Probably, this select is just some unintended left-over from an earlier > draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the > repository. So, drop this dead select to an undefined config. > > Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies") > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> Acked-by: Tejun Heo <tj@kernel.org> Thanks.
diff --git a/block/Kconfig b/block/Kconfig index c6ce41a5e5b2..486bc6003b9e 100644 --- a/block/Kconfig +++ b/block/Kconfig @@ -133,7 +133,6 @@ config BLK_CGROUP_FC_APPID config BLK_CGROUP_IOCOST bool "Enable support for cost model based cgroup IO controller" depends on BLK_CGROUP - select BLK_RQ_IO_DATA_LEN select BLK_RQ_ALLOC_TIME help Enabling this option enables the .weight interface for cost
Commit cd006509b0a9 ("blk-iocost: account for IO size when testing latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in config BLK_CGROUP_IOCOST. Hence, ./scripts/checkkconfigsymbols.py warns: BLK_RQ_IO_DATA_LEN Referencing files: block/Kconfig Probably, this select is just some unintended left-over from an earlier draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the repository. So, drop this dead select to an undefined config. Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies") Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com> --- block/Kconfig | 1 - 1 file changed, 1 deletion(-)