| Message ID | 20211118235738.1128085-1-tadeusz.struk@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [5.15] block: Add a helper to validate the block size | expand |
On 2021/11/19 8:57, Tadeusz Struk wrote: > From: Xie Yongji <xieyongji@bytedance.com> > > From: Xie Yongji <xieyongji@bytedance.com> > > There are some duplicated codes to validate the block > size in block drivers. This limitation actually comes > from block layer, so this patch tries to add a new block > layer helper for that. > > Signed-off-by: Xie Yongji <xieyongji@bytedance.com> > Link: https://lore.kernel.org/r/20211026144015.188-2-xieyongji@bytedance.com > Signed-off-by: Jens Axboe <axboe@kernel.dk> > Signed-off-by: Tadeusz Struk <tadeusz.struk@linaro.org> > --- > include/linux/blkdev.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h > index 683aee365420..5b03795ae33b 100644 > --- a/include/linux/blkdev.h > +++ b/include/linux/blkdev.h > @@ -54,6 +54,14 @@ struct blk_keyslot_manager; > */ > #define BLKCG_MAX_POLS 6 > > +static inline int blk_validate_block_size(unsigned int bsize) > +{ > + if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize)) > + return -EINVAL; > + > + return 0; > +} > + > typedef void (rq_end_io_fn)(struct request *, blk_status_t); > > /* > But where is this used in 5.15 ? I do not see any callers for this. So why backport it ?
On 11/18/21 17:55, Damien Le Moal wrote: > But where is this used in 5.15 ? I do not see any callers for this. > So why backport it ? It will be used after the af3c570fb0df ("loop: Use blk_validate_block_size() to validate block size") is applied. Please read the first message in the thread to get the context.
On 2021/11/19 11:41, Tadeusz Struk wrote: > On 11/18/21 17:55, Damien Le Moal wrote: >> But where is this used in 5.15 ? I do not see any callers for this. >> So why backport it ? > It will be used after the > af3c570fb0df ("loop: Use blk_validate_block_size() to validate block size") > is applied. > Please read the first message in the thread to get the context. None of the patches in that series are marked for stable. If you want all of them backported, sending all patches together as a series would make things easier to understand.
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h index 683aee365420..5b03795ae33b 100644 --- a/include/linux/blkdev.h +++ b/include/linux/blkdev.h @@ -54,6 +54,14 @@ struct blk_keyslot_manager; */ #define BLKCG_MAX_POLS 6 +static inline int blk_validate_block_size(unsigned int bsize) +{ + if (bsize < 512 || bsize > PAGE_SIZE || !is_power_of_2(bsize)) + return -EINVAL; + + return 0; +} + typedef void (rq_end_io_fn)(struct request *, blk_status_t); /*