| Message ID | 20220122111054.1126146-7-ming.lei@redhat.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | block: don't drain file system I/O on del_gendisk | expand |
On Sat, Jan 22, 2022 at 07:10:47PM +0800, Ming Lei wrote: > The queue's top debugfs dir is removed from blk_release_queue(), so all > hctx's debugfs dirs are removed from there. Given blk_mq_exit_queue() > is only called from blk_cleanup_queue(), it isn't necessary to remove > hctx debugfs from blk_mq_exit_queue(). > > So remove it from blk_mq_exit_queue(). Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
diff --git a/block/blk-mq.c b/block/blk-mq.c index 0d25cc5778c9..66cc701921c1 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -3454,7 +3454,6 @@ static void blk_mq_exit_hw_queues(struct request_queue *q, queue_for_each_hw_ctx(q, hctx, i) { if (i == nr_queue) break; - blk_mq_debugfs_unregister_hctx(hctx); blk_mq_exit_hctx(q, set, hctx, i); } }
The queue's top debugfs dir is removed from blk_release_queue(), so all hctx's debugfs dirs are removed from there. Given blk_mq_exit_queue() is only called from blk_cleanup_queue(), it isn't necessary to remove hctx debugfs from blk_mq_exit_queue(). So remove it from blk_mq_exit_queue(). Signed-off-by: Ming Lei <ming.lei@redhat.com> --- block/blk-mq.c | 1 - 1 file changed, 1 deletion(-)