From patchwork Tue Mar 8 05:51:56 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 12772994 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC7A4C433F5 for ; Tue, 8 Mar 2022 05:52:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245575AbiCHFxo (ORCPT ); Tue, 8 Mar 2022 00:53:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344287AbiCHFxe (ORCPT ); Tue, 8 Mar 2022 00:53:34 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D7E12AEB; Mon, 7 Mar 2022 21:52:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description; bh=JANkEFHHfjZyPR6miGkscmr3ZdzOwSYp1qXO2PrN6lc=; b=o+g6BcrU+HFXCzLsOfKAb8H+wh t8val6m6x3X0g9HNCfWDrAQ4GP7bYJwYZMiNu1V3hRxVYTMB8jus8t5Yb3JcXGi+3GrCwoyC85mBl Tb0v0nN2g+l4M2+Fwv8IXevcnLZ7iOOMbHVpNTI/K0+fQa0oEfZ84HIPDEVzCGECafPI2mQX60jir 8k8Mf/0lF8ewx7firwrA9gQgEXIdo4gGpjlG37Q/nJ77oKB0oVtOL6hd3MzCtbQoHcl5Ohw5IyHMa KvvNyuL56SabmakLmV4R6Aij67HyrcGRDFh02YHhGvwLB/bu6yRGwD0PKE7YmPKrWDLBq8O3S1fLi k5GQoCag==; Received: from [2001:4bb8:184:7746:6f50:7a98:3141:c37b] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1nRSln-002irl-6M; Tue, 08 Mar 2022 05:52:27 +0000 From: Christoph Hellwig To: Jens Axboe Cc: "Martin K. Petersen" , Ming Lei , Bart Van Assche , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org Subject: [PATCH 10/14] block: don't remove hctx debugfs dir from blk_mq_exit_queue Date: Tue, 8 Mar 2022 06:51:56 +0100 Message-Id: <20220308055200.735835-11-hch@lst.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220308055200.735835-1-hch@lst.de> References: <20220308055200.735835-1-hch@lst.de> MIME-Version: 1.0 X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org From: Ming Lei The queue's top debugfs dir is removed from blk_release_queue(), so all hctx's debugfs dirs are removed from there. Given blk_mq_exit_queue() is only called from blk_cleanup_queue(), it isn't necessary to remove hctx debugfs from blk_mq_exit_queue(). So remove it from blk_mq_exit_queue(). Signed-off-by: Ming Lei Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 6fd0b0f652514..b38e125a710c9 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -3434,7 +3434,6 @@ static void blk_mq_exit_hw_queues(struct request_queue *q, queue_for_each_hw_ctx(q, hctx, i) { if (i == nr_queue) break; - blk_mq_debugfs_unregister_hctx(hctx); blk_mq_exit_hctx(q, set, hctx, i); } }