| Message ID | 20220504142950.567582-2-hch@lst.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] block: remove superfluous calls to blkcg_bio_issue_init | expand |
On Wed, May 04 2022 at 10:29P -0400, Christoph Hellwig <hch@lst.de> wrote: > blkcg_bio_issue_init is called in submit_bio. There is no need to have > extra calls that just get overriden in __bio_clone and the two places > that copy and pasted from it. > > Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Mike Snitzer <snitzer@kernel.org>
On Wed, 4 May 2022 07:29:49 -0700, Christoph Hellwig wrote: > blkcg_bio_issue_init is called in submit_bio. There is no need to have > extra calls that just get overriden in __bio_clone and the two places > that copy and pasted from it. > > Applied, thanks! [1/2] block: remove superfluous calls to blkcg_bio_issue_init commit: 513616843d736fb7161b4460cdfe5aa825c5902c [2/2] block: allow passing a NULL bdev to bio_alloc_clone/bio_init_clone commit: 7ecc56c62b27d93838ee67fc2c7a1c3c480aea04 Best regards,
diff --git a/block/bio.c b/block/bio.c index 4259125e16ab2..3cffc01e6377f 100644 --- a/block/bio.c +++ b/block/bio.c @@ -739,7 +739,6 @@ static int __bio_clone(struct bio *bio, struct bio *bio_src, gfp_t gfp) bio->bi_iter = bio_src->bi_iter; bio_clone_blkg_association(bio, bio_src); - blkcg_bio_issue_init(bio); if (bio_crypt_clone(bio, bio_src, gfp) < 0) return -ENOMEM; diff --git a/block/blk-crypto-fallback.c b/block/blk-crypto-fallback.c index 7c854584b52b5..5ddf33f999dfe 100644 --- a/block/blk-crypto-fallback.c +++ b/block/blk-crypto-fallback.c @@ -177,7 +177,6 @@ static struct bio *blk_crypto_fallback_clone_bio(struct bio *bio_src) bio->bi_io_vec[bio->bi_vcnt++] = bv; bio_clone_blkg_association(bio, bio_src); - blkcg_bio_issue_init(bio); return bio; } diff --git a/block/bounce.c b/block/bounce.c index 467be46d0e656..8f7b6fe3b4db5 100644 --- a/block/bounce.c +++ b/block/bounce.c @@ -191,7 +191,6 @@ static struct bio *bounce_clone_bio(struct bio *bio_src) goto err_put; bio_clone_blkg_association(bio, bio_src); - blkcg_bio_issue_init(bio); return bio;
blkcg_bio_issue_init is called in submit_bio. There is no need to have extra calls that just get overriden in __bio_clone and the two places that copy and pasted from it. Signed-off-by: Christoph Hellwig <hch@lst.de> --- block/bio.c | 1 - block/blk-crypto-fallback.c | 1 - block/bounce.c | 1 - 3 files changed, 3 deletions(-)