| Message ID | 20220513193831.4136212-2-mcgrof@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | kdevops: use linux-kdevops for the main tree | expand |
On 5/13/22 12:38, Luis Chamberlain wrote: > We have two kconfig variables which we use to be able to express > when we are going to enable fstests or blktests, either as a dedicated > set of tests or when we want to enable testing both fstests and blktests > in one system. But right now we only select this kconfig variable when > we are using a dedicated system. This is not an issue as the kconfig > is a kconfig symbols are bools which are set default to y if either > the test is dedicated or not. > > But to be pedantic, and clear, let's make sure the tests select the > respective kconfig for each case as we'd expect to see it. Otherwise > this can confuse folks reading this. Is this patch perhaps intended for the kdevops project? If so, please add a prefix to make this clear (git format-patch --subject-prefix) when sending kdevops patches to Linux kernel mailing lists. Thanks, Bart.
On Fri, May 13, 2022 at 07:21:56PM -0700, Bart Van Assche wrote: > On 5/13/22 12:38, Luis Chamberlain wrote: > > We have two kconfig variables which we use to be able to express > > when we are going to enable fstests or blktests, either as a dedicated > > set of tests or when we want to enable testing both fstests and blktests > > in one system. But right now we only select this kconfig variable when > > we are using a dedicated system. This is not an issue as the kconfig > > is a kconfig symbols are bools which are set default to y if either > > the test is dedicated or not. > > > > But to be pedantic, and clear, let's make sure the tests select the > > respective kconfig for each case as we'd expect to see it. Otherwise > > this can confuse folks reading this. > > Is this patch perhaps intended for the kdevops project? If so, please add a > prefix to make this clear (git format-patch --subject-prefix) when sending > kdevops patches to Linux kernel mailing lists. Yeah good idea for it to go into the [PATCH kdevops]. Thanks! Luis
diff --git a/kconfigs/workflows/Kconfig b/kconfigs/workflows/Kconfig index 7e5c518..7f71470 100644 --- a/kconfigs/workflows/Kconfig +++ b/kconfigs/workflows/Kconfig @@ -133,6 +133,7 @@ if !WORKFLOWS_DEDICATED_WORKFLOW config KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_FSTESTS bool "fstests" + select KDEVOPS_WORKFLOW_ENABLE_FSTESTS help Select this option if you are doing filesystem development and want to target development for a filesystem and enable fstests so that @@ -146,6 +147,7 @@ config KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_FSTESTS config KDEVOPS_WORKFLOW_NOT_DEDICATED_ENABLE_BLKTESTS bool "blktests" + select KDEVOPS_WORKFLOW_ENABLE_BLKTESTS help Select this option if you are doing block layer development and want to run blktests. The git tree for blktests will be git clone and
We have two kconfig variables which we use to be able to express when we are going to enable fstests or blktests, either as a dedicated set of tests or when we want to enable testing both fstests and blktests in one system. But right now we only select this kconfig variable when we are using a dedicated system. This is not an issue as the kconfig is a kconfig symbols are bools which are set default to y if either the test is dedicated or not. But to be pedantic, and clear, let's make sure the tests select the respective kconfig for each case as we'd expect to see it. Otherwise this can confuse folks reading this. Signed-off-by: Luis Chamberlain <mcgrof@kernel.org> --- kconfigs/workflows/Kconfig | 2 ++ 1 file changed, 2 insertions(+)