diff mbox series

[blktests,4/9] common: do not require loop support to be modular

Message ID 20220530130811.3006554-5-hch@lst.de (mailing list archive)
State New, archived
Headers show
Series [blktests,1/9] nvme: use _have_loop instead of _have_modules loop | expand

Commit Message

Christoph Hellwig May 30, 2022, 1:08 p.m. UTC
Use _have_driver instead of _have_modules in _have_loop as nothing requires
the loop driver to be modular.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 common/rc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shin'ichiro Kawasaki May 31, 2022, 11:19 a.m. UTC | #1
On May 30, 2022 / 15:08, Christoph Hellwig wrote:
> Use _have_driver instead of _have_modules in _have_loop as nothing requires
> the loop driver to be modular.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks good to me.

Reviewed-by: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
diff mbox series

Patch

diff --git a/common/rc b/common/rc
index ffd15b6..d71a81e 100644
--- a/common/rc
+++ b/common/rc
@@ -128,7 +128,7 @@  _have_src_program() {
 }
 
 _have_loop() {
-	_have_modules loop && _have_program losetup
+	_have_driver loop && _have_program losetup
 }
 
 _have_blktrace() {